Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LooperMode.LEGACY from tests that do not need it #761

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove LooperMode.LEGACY from tests that do not need it #761

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24f2ca9
Remove LooperMode.LEGACY from tests that do not need it
chggr Jan 26, 2021
ac2a5d0
Merge branch 'master' into loopermode
chggr Feb 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions litho-it/src/test/java/com/facebook/litho/animation/AnimatedPropertyNodeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,7 @@
import org.junit.Test;
import org.junit.rules.ExpectedException;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class AnimatedPropertyNodeTest {

Expand Down
2 changes: 0 additions & 2 deletions litho-it/src/test/java/com/facebook/litho/choreographercompat/ChoreographerCompatTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,8 @@
import java.util.concurrent.atomic.AtomicReference;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;
import org.robolectric.shadows.ShadowLooper;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class ChoreographerCompatTest {

Expand Down
2 changes: 0 additions & 2 deletions litho-it/src/test/java/com/facebook/litho/dataflow/DataFlowGraphTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,7 @@
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class DataFlowGraphTest {

Expand Down
2 changes: 0 additions & 2 deletions litho-it/src/test/java/com/facebook/litho/dataflow/GraphBindingFinishesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,7 @@
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class GraphBindingFinishesTest {

Expand Down
2 changes: 0 additions & 2 deletions litho-it/src/test/java/com/facebook/litho/dataflow/InterpolatorNodeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,7 @@
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class InterpolatorNodeTest {

Expand Down
2 changes: 0 additions & 2 deletions litho-it/src/test/java/com/facebook/litho/dataflow/MappingNodeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,7 @@
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class MappingNodeTest {

Expand Down
2 changes: 0 additions & 2 deletions litho-it/src/test/java/com/facebook/litho/dataflow/MockTimingSourceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,7 @@
import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.Mockito;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class MockTimingSourceTest {

Expand Down
2 changes: 0 additions & 2 deletions litho-it/src/test/java/com/facebook/litho/dataflow/TimingNodeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,7 @@
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class TimingNodeTest {

Expand Down
2 changes: 0 additions & 2 deletions litho-it/src/test/java/com/facebook/litho/drawable/ComparableGradientDrawableTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,7 @@
import com.facebook.litho.testing.testrunner.LithoTestRunner;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class ComparableGradientDrawableTest {

Expand Down
2 changes: 0 additions & 2 deletions litho-it/src/test/java/com/facebook/litho/sections/BatchedTargetTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,8 @@
import org.mockito.ArgumentCaptor;
import org.mockito.Captor;
import org.mockito.MockitoAnnotations;
import org.robolectric.annotation.LooperMode;

/** Tests {@link BatchedTarget} */
@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class BatchedTargetTest {

Expand Down
2 changes: 0 additions & 2 deletions litho-it/src/test/java/com/facebook/litho/sections/ChangeSetStateTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,8 @@
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

/** Tests {@link ChangeSetState} */
@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class ChangeSetStateTest {
private SectionContext mSectionContext;
Expand Down
2 changes: 0 additions & 2 deletions litho-it/src/test/java/com/facebook/litho/sections/ChangeSetStatsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,7 @@
import com.facebook.litho.testing.testrunner.LithoTestRunner;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class ChangeSetStatsTest {

Expand Down
2 changes: 0 additions & 2 deletions litho-it/src/test/java/com/facebook/litho/sections/ChangeSetTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,8 @@
import java.util.List;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

/** Tests {@link ChangeSet} */
@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class ChangeSetTest {

Expand Down
2 changes: 0 additions & 2 deletions litho-it/src/test/java/com/facebook/litho/sections/ChangeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,8 @@
import java.util.List;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

/** Tests {@link Change} */
@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class ChangeTest {

Expand Down
2 changes: 0 additions & 2 deletions litho-it/src/test/java/com/facebook/litho/sections/ChangesInfoTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,8 @@
import java.util.List;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

/** Tests {@link ChangesInfo} */
@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class ChangesInfoTest {

Expand Down
2 changes: 0 additions & 2 deletions litho-it/src/test/java/com/facebook/litho/sections/FocusDispatcherTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,8 @@
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

/** Tests {@link FocusDispatcher} */
@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class FocusDispatcherTest {

Expand Down
2 changes: 0 additions & 2 deletions litho-it/src/test/java/com/facebook/litho/sections/SectionTreeEventHandlerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,7 @@
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class SectionTreeEventHandlerTest {

Expand Down
2 changes: 0 additions & 2 deletions litho-it/src/test/java/com/facebook/litho/sections/common/DataDiffSectionSpecTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,8 @@
import org.junit.runner.RunWith;
import org.mockito.Mock;
import org.mockito.MockitoAnnotations;
import org.robolectric.annotation.LooperMode;

/** Tests {@link DataDiffSectionSpec} */
@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class DataDiffSectionSpecTest {

Expand Down
2 changes: 0 additions & 2 deletions ...o-it/src/test/java/com/facebook/litho/sections/common/SingleComponentSectionSpecTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,8 @@
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

/** Tests {@link SingleComponentSectionSpec} */
@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class SingleComponentSectionSpecTest {

Expand Down
2 changes: 0 additions & 2 deletions litho-it/src/test/java/com/facebook/litho/sections/processor/TreePropSectionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,8 @@
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.Robolectric;
import org.robolectric.annotation.LooperMode;

/** Tests passing {@link TreeProp}s down a Section tree. */
@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class TreePropSectionTest {

Expand Down
2 changes: 0 additions & 2 deletions ...src/test/java/com/facebook/litho/sections/widget/RecyclerCollectionComponentSpecTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,8 @@
import org.junit.Rule;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

/** Tests {@link RecyclerCollectionComponentSpec} */
@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class RecyclerCollectionComponentSpecTest {

Expand Down
2 changes: 0 additions & 2 deletions litho-it/src/test/java/com/facebook/litho/testing/LithoRepresentationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,7 @@
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class LithoRepresentationTest {

Expand Down
2 changes: 0 additions & 2 deletions litho-it/src/test/java/com/facebook/litho/testing/assertj/SubComponentDeepExtractorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,7 @@
import org.junit.Rule;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class SubComponentDeepExtractorTest {
@Rule public ComponentsRule mComponentsRule = new ComponentsRule();
Expand Down
2 changes: 0 additions & 2 deletions .../src/test/java/com/facebook/litho/testing/specmodels/InjectPropMatcherGenerationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,7 @@
import org.junit.Rule;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class InjectPropMatcherGenerationTest {
@Rule public ComponentsRule mComponentsRule = new ComponentsRule();
Expand Down
2 changes: 0 additions & 2 deletions litho-it/src/test/java/com/facebook/litho/testing/subcomponents/CommonPropMatcherTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,7 @@
import org.junit.Rule;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class CommonPropMatcherTest {
@Rule public ComponentsRule mComponentsRule = new ComponentsRule();
Expand Down
2 changes: 0 additions & 2 deletions .../src/test/java/com/facebook/litho/testing/subcomponents/GenericMatcherGenerationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,7 @@
import org.junit.Rule;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class GenericMatcherGenerationTest {
@Rule public ComponentsRule mComponentsRule = new ComponentsRule();
Expand Down
2 changes: 0 additions & 2 deletions litho-it/src/test/java/com/facebook/litho/testing/viewtree/ViewExtractorsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,8 @@
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.Robolectric;
import org.robolectric.annotation.LooperMode;

/** Tests {@link ViewExtractors} */
@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class ViewExtractorsTest {

Expand Down
2 changes: 0 additions & 2 deletions litho-it/src/test/java/com/facebook/litho/testing/viewtree/ViewTreeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,8 @@
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.Robolectric;
import org.robolectric.annotation.LooperMode;

/** Tests {@link ViewTree} */
@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class ViewTreeTest {

Expand Down
2 changes: 0 additions & 2 deletions litho-it/src/test/java/com/facebook/litho/testing/viewtree/ViewTreeUtilTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,8 @@
import com.facebook.litho.testing.testrunner.LithoTestRunner;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

/** Test for {@link ViewTreeUtil} */
@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class ViewTreeUtilTest {
@Test
Expand Down
2 changes: 0 additions & 2 deletions litho-it/src/test/java/com/facebook/litho/utils/MapDiffUtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,7 @@
import java.util.HashMap;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class MapDiffUtilsTest {

Expand Down
2 changes: 0 additions & 2 deletions litho-it/src/test/java/com/facebook/litho/utils/MeasureUtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,7 @@
import com.facebook.litho.testing.testrunner.LithoTestRunner;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.annotation.LooperMode;

@LooperMode(LooperMode.Mode.LEGACY)
@RunWith(LithoTestRunner.class)
public class MeasureUtilsTest {

Expand Down