Fix ListItemNode serialization throws (#7116)

facebook · Jan 30, 2025 · 03be169 · 03be169
1 parent a62a1a6
commit 03be169
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/packages/lexical-list/src/LexicalListItemNode.ts b/packages/lexical-list/src/LexicalListItemNode.ts
@@ -349,7 +349,7 @@ export class ListItemNode extends ElementNode {
   getIndent(): number {
     // If we don't have a parent, we are likely serializing
     const parent = this.getParent();
-    if (parent === null) {
+    if (parent === null || !this.isAttached()) {
       return this.getLatest().__indent;
     }
     // ListItemNode should always have a ListNode for a parent.

diff --git a/packages/lexical-list/src/__tests__/unit/LexicalListItemNode.test.ts b/packages/lexical-list/src/__tests__/unit/LexicalListItemNode.test.ts
@@ -20,6 +20,7 @@ import {
 
 import {
   $createListItemNode,
+  $createListNode,
   $isListItemNode,
   ListItemNode,
   ListNode,
@@ -1361,5 +1362,24 @@ describe('LexicalListItemNode tests', () => {
         });
       });
     });
+
+    test('Can serialize a node that is not attached', async () => {
+      const {editor} = testEnv;
+      await editor.update(() => {
+        const listItemNode = $createListItemNode();
+        const listNode = $createListNode();
+        listNode.append(listItemNode);
+        expect(listItemNode.exportJSON()).toEqual({
+          checked: undefined,
+          children: [],
+          direction: null,
+          format: '',
+          indent: 0,
+          type: 'listitem',
+          value: 1,
+          version: 1,
+        });
+      });
+    });
   });
 });