Upgrade IJ plugin to new IJP Gradle plugin 2.0

[rock3r]

This is step 1/2 needed to be able to run the ktlint plugin on IJ 24.2, which was just released today to stable. The next step will be to actually fix the crash on 24.2 — another PR coming for that.

[facebook-github-bot]

Hi @rock3r!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[hick209]

Thanks for the contributions here!
I see you also change the Java version to 17, is that a requirement? If so, you'd need to also update the GH workflow files accordingly
https://github.com/facebook/ktfmt/blob/main/.github/workflows/build_and_test.yml#L17
https://github.com/facebook/ktfmt/blob/main/.github/workflows/publish_artifacts_on_release.yaml#L29

[rock3r]

I have had a lot of pain trying to use an older JDK version than 17 with more recent tooling, so while not strictly mandatory, it's strongly advisable to. This still allows us to support 2 year old IJ versions.

I'll update the actions definition accordingly.

[rock3r]

All done, and rebased the other PRs on top

[hick209]

Looks like you still have errors in the build jobs

[rock3r]

@hick209 sorry! Difficult to test on a fork :)

[rock3r]

There was a failing test (not impacted by my changes), I fixed it...

[rock3r]

CI's green on my fork, hopefully we've gotten it to build again :)

[rock3r]

Yay!

[hick209]

Let's try to ship this! I just need approval from someone else from my team and we should be good to go.

[facebook-github-bot]

@hick209 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[rock3r]

Aye. Hopefully y'all can cut a release soon. I built a zip with the version bumped to 1.2 for personal use in the meantime, so I can use ktfmt in IJ 24.2

[hick209]

Linter is failing for formatting, but I've fixed that internally already.
I'll try to merge this in and the other PRs today so we can cut a release yet this week 🚀

[rock3r]

Kind of odd the formatting is tripping up the linter, I ran spotlessApply...

[hick209]

That's on us, we haven't really setup spotless to format kotlin code. I'll try to fix that next

[facebook-github-bot]

@hick209 merged this pull request in 09cdd27.