Fix renameTo false positive for JSX tags #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
henryqdineen
force-pushed
the
hqd-rename-jsx-tags
branch
3 times, most recently
from
76c8c25
to
5ce5704
Compare
henryqdineen
force-pushed
the
hqd-rename-jsx-tags
branch
from
5ce5704
to
a8fe7a1
Compare
|
Good catch! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an edge case that we ran into where JSX tags are inadvertently renamed when they are "built-in" components like
<div>or<span>. We should only consider capitalized tags as variable references (see React docs). For this PR I used the the same regex as the JSX Babel transform for consistency.I understand that this logic is React-specific and there could be JSX usage that does not follow these conventions. Ideally this could be configurable.