[flow] Stop suggesting React$MixedElement and React$Node

Summary:
These types can be used without import, so the logic is no longer necessary. It will help stop the bleed of introducing more of these internal types.

Changelog: [internal]

Reviewed By: gkz

Differential Revision: D67480565

fbshipit-source-id: 6bfbc3e645ee15ffe905097f37991892e7725ce9

src/services/code_action/insert_type_utils.ml

@@ -1212,13 +1212,8 @@ class type_normalization_hardcoded_fixes_mapper
             kind,
             Some [(Ty.Str _ | Ty.StrLit _)]
           )
-        when is_react_loc sym_def_loc && imports_react ->
-        let name =
-          if imports_react then
-            "React.MixedElement"
-          else
-            "React$MixedElement"
-        in
+        when is_react_loc sym_def_loc ->
+        let name = "React.MixedElement" in
         let symbol = { symbol with Ty.sym_name = Reason.OrdinaryName name } in
         this#on_t env Ty.(Generic (symbol, kind, None))
       (* E.g. React$Element<typeof A> will become React.MixedElement or React.Node.
@@ -1238,14 +1233,9 @@ class type_normalization_hardcoded_fixes_mapper
         when is_react_loc sym_def_loc ->
         let name =
           if generalize_react_mixed_element then
-            if imports_react then
-              "React.MixedElement"
-            else
-              "React$MixedElement"
-          else if imports_react then
-            "React.Node"
+            "React.MixedElement"
           else
-            "React$Node"
+            "React.Node"
         in
         let symbol = { symbol with Ty.sym_name = Reason.OrdinaryName name } in
         this#on_t env Ty.(Generic (symbol, kind, None))

tests/annotate_exports_react/annotate_exports_react.exp

@@ -28,7 +28,7 @@ import React from 'react';
 
 type Props = {}
 
-export default (): React$MixedElement => {
+export default (): React.MixedElement => {
   class Abc extends React.Component<Props> { }
   return <Abc/>;
 }
@@ -151,7 +151,7 @@ import React from 'react';
 
 type Props = {}
 
-export default (): React$MixedElement => {
+export default (): React.MixedElement => {
   class Abc extends React.Component<Props> { }
   return <Abc/>;
 }

tests/annotate_exports_simplify_hardcoded_fixes/annotate_exports_simplify_hardcoded_fixes.exp

@@ -6,7 +6,7 @@
 
 declare function f(): ExactReactElement_DEPRECATED<'a'> | ExactReactElement_DEPRECATED<'b'>;
 
-module.exports = (f() as React$MixedElement);
+module.exports = (f() as React.MixedElement);
 
 >>> Launching report...
 
@@ -42,7 +42,7 @@ Warnings:
 
 declare function f(): ExactReactElement_DEPRECATED<'a'> | ExactReactElement_DEPRECATED<'b'>;
 
-module.exports = (f() as React$MixedElement);
+module.exports = (f() as React.MixedElement);
 
 
 === Diff between codemod-ed & autofix-ed ===

tests/autofix_simplify_hardcoded_fixes/autofix_simplify_hardcoded_fixes.exp

@@ -3,6 +3,6 @@
 
 declare function f(): ExactReactElement_DEPRECATED<'a'> | ExactReactElement_DEPRECATED<'b'>;
 
-module.exports = (f() as React$MixedElement);
+module.exports = (f() as React.MixedElement);
 > flow status
 No errors!