Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip hanging tests #5662

Closed
wants to merge 2 commits into from
Closed

Skip hanging tests #5662

wants to merge 2 commits into from

Conversation

antonk52
Copy link
Contributor

A couple of tests have open handlers that cause jest to timeout in GitHub actions. Skipping these should fix the step to allow other jobs to run

Example failure

https://github.com/facebook/flipper/actions/runs/10083622244/job/27880598756#step:8:762

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jul 29, 2024
Copy link
Contributor

github-actions bot commented Jul 29, 2024

Pull Request Test Coverage Report for Build 10147072360

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 48 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.2%) to 51.029%

Files with Coverage Reduction New Missed Lines %
desktop/flipper-server/src/devices/ios/iOSCertificateProvider.tsx 3 14.13%
desktop/flipper-server/src/devices/ios/iOSCrashUtils.tsx 3 55.36%
desktop/flipper-server/src/devices/ServerDevice.tsx 6 8.33%
desktop/flipper-server/src/devices/ios/IOSDevice.tsx 7 14.12%
desktop/flipper-server/src/devices/ios/iOSLogListener.tsx 8 17.02%
desktop/flipper-server/src/devices/ios/iOSDeviceManager.tsx 21 21.43%
Totals Coverage Status
Change from base Build 10114576751: -0.2%
Covered Lines: 8122
Relevant Lines: 15002

💛 - Coveralls

@antonk52 antonk52 marked this pull request as ready for review July 29, 2024 15:29
@facebook-github-bot
Copy link
Contributor

@antonk52 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@antonk52 merged this pull request in 5f4f25f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants