Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ios autolinking only on debug build #4485

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Kudo
Copy link

@Kudo Kudo commented Feb 2, 2023

Summary

Enable react-native-flipper iOS autolinking only on debug build. Fixes #4457

Changelog

Fix react-native-flipper iOS release build error

Test Plan

$ npx react-native init RN071 --version 0.71
$ cd RN071
$ yarn add [email protected]

# update ios/Podfile with next line
flipper_config = ENV['NO_FLIPPER'] == "1" ? FlipperConfiguration.disabled : FlipperConfiguration.enabled(["Debug"], { 'Flipper' => '0.174.0' })

$ npx pod-install

# open xcode and test release build

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 2, 2023
@passy
Copy link
Member

passy commented Feb 3, 2023

@lblasa Could you take a look?

@coveralls
Copy link

coveralls commented Feb 3, 2023

Pull Request Test Coverage Report for Build 4166321456

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 51.048%

Files with Coverage Reduction New Missed Lines %
desktop/test-utils/src/pathUtils.tsx 2 57.14%
Totals Coverage Status
Change from base Build 4163793639: 0.0%
Covered Lines: 8153
Relevant Lines: 14580

💛 - Coveralls

@Kudo Kudo force-pushed the ios-autolinking-debug-only branch from b3febfd to 47347c2 Compare February 3, 2023 13:33
@Kudo
Copy link
Author

Kudo commented Feb 3, 2023

looks like ci is failed at unrelated place. let me rebase the branch, please help to re-run ci again. thanks!

@Kudo
Copy link
Author

Kudo commented Feb 13, 2023

@lblasa appreciate if you could help to approve the ci running again.

@mweststrate
Copy link
Contributor

enabled

@Kudo
Copy link
Author

Kudo commented Feb 14, 2023

thanks! the ci checks are all passed now. appreciate again if someone could import/merge this pr.

@janicduplessis
Copy link
Contributor

Bump this, I had a similar issue and can confirm this fixes it.

@jacquesdev
Copy link

Could we please get this merged?

@ChrisWiles
Copy link

Bump this, I had a similar issue and can confirm this fixes it.

@nihilenz
Copy link

nihilenz commented Nov 2, 2023

Any news? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

react-native-flipper 0.171 and up are causing linking errors on iOS Release build
9 participants