Support formatting network request

facebook · Jul 13, 2024 · b25462c · b25462c
1 parent 1246c8b
commit b25462c
Show file tree

Hide file tree

Showing 2 changed files with 43 additions and 3 deletions.
diff --git a/...gins/network/src/main/java/com/facebook/flipper/plugins/network/NetworkFlipperPlugin.java b/...gins/network/src/main/java/com/facebook/flipper/plugins/network/NetworkFlipperPlugin.java
@@ -8,25 +8,36 @@
 package com.facebook.flipper.plugins.network;
 
 import android.util.Base64;
+
 import com.facebook.flipper.core.ErrorReportingRunnable;
 import com.facebook.flipper.core.FlipperArray;
 import com.facebook.flipper.core.FlipperObject;
 import com.facebook.flipper.plugins.common.BufferingFlipperPlugin;
+
 import java.util.Arrays;
 import java.util.List;
+
 import javax.annotation.Nullable;
 
 public class NetworkFlipperPlugin extends BufferingFlipperPlugin implements NetworkReporter {
   public static final String ID = "Network";
   private static final int MAX_BODY_SIZE_IN_BYTES = 1024 * 1024;
+
   private List<NetworkResponseFormatter> mFormatters;
+  private final List<NetworkRequestFormatter> mRequestFormatters;
 
   public NetworkFlipperPlugin() {
     this(null);
   }
 
   public NetworkFlipperPlugin(List<NetworkResponseFormatter> formatters) {
     this.mFormatters = formatters;
+    this.mRequestFormatters = null;
+  }
+
+  public NetworkFlipperPlugin(List<NetworkResponseFormatter> formatters, List<NetworkRequestFormatter> requestFormatters) {
+    this.mFormatters = formatters;
+    this.mRequestFormatters = requestFormatters;
   }
 
   @Override
@@ -40,7 +51,7 @@ public void setFormatters(List<NetworkResponseFormatter> formatters) {
 
   @Override
   public void reportRequest(final RequestInfo requestInfo) {
-    (new ErrorReportingRunnable(getConnection()) {
+    final Runnable job = new ErrorReportingRunnable(getConnection()) {
           @Override
           protected void runOrThrow() throws Exception {
             final FlipperObject request =
@@ -55,8 +66,26 @@ protected void runOrThrow() throws Exception {
 
             send("newRequest", request);
           }
-        })
-        .run();
+    };
+
+    if (mRequestFormatters != null) {
+      for (NetworkRequestFormatter formatter : mRequestFormatters) {
+        if (formatter.shouldFormat(requestInfo)) {
+          formatter.format(
+                  requestInfo,
+                  new NetworkRequestFormatter.OnCompletionListener() {
+                    @Override
+                    public void onCompletion(final String json) {
+                      requestInfo.body = json.getBytes();
+                      job.run();
+                    }
+                  });
+          return;
+        }
+      }
+    }
+
+    job.run();
   }
 
   @Override

diff --git a/...s/network/src/main/java/com/facebook/flipper/plugins/network/NetworkRequestFormatter.java b/...s/network/src/main/java/com/facebook/flipper/plugins/network/NetworkRequestFormatter.java
@@ -0,0 +1,11 @@
+package com.facebook.flipper.plugins.network;
+
+public interface NetworkRequestFormatter {
+    interface OnCompletionListener {
+        void onCompletion(String json);
+    }
+
+    boolean shouldFormat(NetworkReporter.RequestInfo request);
+
+    void format(NetworkReporter.RequestInfo request, OnCompletionListener onCompletionListener);
+}