fixFBRetainCycleDetectorIssues96 #79
Conversation
|
Hi @guoxiaomind! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Tested this fix, working fine. Please merge ASAP, thank you |
| @@ -134,7 +134,9 @@ static void perform_rebinding_with_section(struct rebindings_entry *rebindings, | |||
| indirect_symbol_bindings[i] != cur->rebindings[j].replacement) { | |||
| *(cur->rebindings[j].replaced) = indirect_symbol_bindings[i]; | |||
| } | |||
| indirect_symbol_bindings[i] = cur->rebindings[j].replacement; | |||
| if(i < (sizeof(indirect_symbol_bindings) /sizeof(indirect_symbol_bindings[0]))) { | |||
There was a problem hiding this comment.
sizeof(indirect_symbol_bindings) /sizeof(indirect_symbol_bindings[0])
Always return 1 which make the replacement code unreachable:
indirect_symbol_bindings[i] = cur->rebindings[j].replacement;
The crash is eliminated because the functionality is eliminated.
fix fishhook.c crash