Skip to content

Commit

Permalink
Remove -it flags from docker-unittest.py
Browse files Browse the repository at this point in the history
Summary:
Attempting to attach to terminal when running unit tests during github actions
will result in a failure as there is no active stdin.

Reviewed By: srikrishnagopu

Differential Revision: D61863442

fbshipit-source-id: bc1f8e5017493dea83a4227312ff3f70f422ada1
  • Loading branch information
paulcruz74 authored and facebook-github-bot committed Aug 27, 2024
1 parent 020638a commit c91e6ba
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion fboss/oss/scripts/github_actions/docker-unittest.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ def run_test(test: str, output_dir: str) -> bool:
cmd_args.extend(["-v", f"{output_dir}:{output_dir}:z"])
# Add required capability for sudo permissions
cmd_args.append("--cap-add=CAP_AUDIT_WRITE")
cmd_args.append("-it")
cmd_args.append(f"{FBOSS_IMAGE_NAME}:latest")
test_path = os.path.join(output_dir, "bin", test)
cmd_args.append(test_path)
Expand Down

0 comments on commit c91e6ba

Please sign in to comment.