[Ramp up] Adding test for Product feed Create API call #2872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mradmeta
reviewed
Feb 10, 2025
| $product = WC_Helper_Product::create_simple_product(); | ||
| $facebook_product = new WC_Facebook_Product( $product ); | ||
| $product_group_id = 'facebook-product-group-id'; | ||
| $data = $facebook_product->prepare_product(); |
There was a problem hiding this comment.
So I know the contents of the data variable here dont actually matter because its not typed and acutally used for anything in this test, but it feels weird to set what reads as product data as the data to create a ProductFeed
|
@jczhuoMeta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding tests to Product Feed Creation to as ramp up task
Test: npm run test:php