Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 3.3.3 #2868

Merged
merged 18 commits into from
Feb 6, 2025
Merged

Release 3.3.3 #2868

merged 18 commits into from
Feb 6, 2025

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 6, 2025

Checklist

  1. Check if the version, base, and target branches are as you desire.
  2. Make sure you have woorelease installed and set up.
  3. Go to your local repo clone, and check out this PR to be able to commit any potential adjustments. 
    git fetch origin release/3.3.3
git checkout release/3.3.3
  4. Simulate the release locally 
    woorelease simulate --product_version=3.3.3  --wp_tested=6.7 --wc_tested=9.6 --generate_changelog https://github.com/facebook/facebook-for-woocommerce/tree/release/3.3.3
    Note: Select y when prompted: "Would you like to add/delete them in the svn working copy?"
  5. The changelog is correct.
    Check if some entries are missing, need rewording, or need to be deleted. You can edit respective PRs by changing their title, ### Changelog entry section, or assigning the changelog: none label.
    You can also edit the changelog manually in the woorelease release step later.
  6. Automated tests are passing.
  7. Test the package
    1. Install the /tmp/facebook-for-woocommerce.zip file on a test site
    2. Confirm it activates without warnings/errors and is showing the right versions
    3. Run a few basic smoke tests

Next steps

  1. Do the final release 
    woorelease release --product_version=3.3.3  --wp_tested=6.7 --wc_tested=9.6  --generate_changelog https://github.com/facebook/facebook-for-woocommerce/tree/release/3.3.3
    When prompted for changelog entries, double-check and apply any changes if needed.
  2. Go to https://github.com/facebook/facebook-for-woocommerce/releases/3.3.3, generate GitHub release notes, and paste them as a comment here.
  3. Merge this PR after the new release is successfully created and the version tags are updated.
  4. Merge trunk to develop (PR), if applicable for this repo.
  5. Update documentation
    • Publish any new required docs
    • Update triggers/rules/actions listing pages
  6. Mark related ideas complete on the feature requests page.

After deploy

  1. Confirm the release deployed correctly to WPORG.
    • Ensure you can download and install the latest release from WPORG and WCCOM.
    • We've had an issue where the release tag (e.g. 2.6.1) wasn't present in the svn tags/ folder.
    • Troubleshooting processes when the release version doesn't exist in the svn tags/ folder:
      1. Check the version by Stable tag in https://plugins.svn.wordpress.org/facebook-for-woocommerce/trunk/readme.txt to see if the new release is committed to trunk
      2. If the above version is the same as the one just released, then you can make up the missed version tag by svn cp https://plugins.svn.wordpress.org/facebook-for-woocommerce/trunk https://plugins.svn.wordpress.org/facebook-for-woocommerce/tags/X.X.X -m "Tagging version X.X.X". Please note that the X.X.X is used as a placeholder but should be replaced with the actual release version (e.g., 1.5.0).
      3. Wait for a while, and the zip file should be able to download from: https://downloads.wordpress.org/plugin/facebook-for-woocommerce.x.x.x.zip
  2. Close the release milestone.
  3. Publish any documentation updates relating to the release:

halilozanakgul and others added 15 commits January 21, 2025 16:16
@halilozanakgul
Update php-unit-tests.yml to install SVN (#2859)
6530a5a
@vinkmeta
Fix: get_global_unique_id function compatibility check (#2856)
76f0a2e 
Summary:
Fixed a bug that arose from our reliance on the plugin version compatibility tag for the public function get_global_unique_id. This function was actually introduced in WooCommerce version 9.2, but was incorrectly tagged as being available from version 9.1 onwards.
To ensure correct functionality, we have replaced the use of Compatibility::is_wc_version_gte() with method_exists(), which checks for the availability of specific public methods rather than relying on version numbers

Differential Revision: D68424348
@devbodaghe @mshymon
Update catalog link to navigate to correct tab in Commerce Manager (#…
62f93a6 
…2848)

* Update catalog link to navigate to correct tab in Commerce Manager

Co-authored-by: Marian Shymon <[email protected]>

---------

Co-authored-by: David Evbodaghe <[email protected]>
Co-authored-by: Marian Shymon <[email protected]>
@vinkmeta
Fixed product url links (#2852)
0072f1c
@mshymon @halilozanakgul
Fix - Removed the "Sell on Instagram" checkbox from UX and cleaned up…
48d739a 
… the backend (#2854)

* Removed the  Sell on Instagram UX and cleane dup the backend.

* Update php-unit-tests.yml to install SVN (#2859)

---------

Co-authored-by: Marian Shymon <[email protected]>
Co-authored-by: Halil Ozan Akgül <[email protected]>
@devbodaghe
feat: Add custom fields to product data structure (#2836)
5c7cef9 
* feat: Add custom fields to product data structure

---------

Co-authored-by: David Evbodaghe <[email protected]>
@vinkmeta
Fixed Category specific attributes related issues (#2860)
00f5ff1
@vahidkay-meta @github-actions
@halilozanakgul @vinkmeta @devbodaghe @mshymon
Merging Trunk into Develop branch (#2850)
d0afc3f 
* Start `release/3.3.1`.

* Updated the version number to 3.3.1

* Release 3.3.2 (#2861)

* Update php-unit-tests.yml to install SVN (#2859)

* Fix: get_global_unique_id function compatibility check (#2856)

Summary:
Fixed a bug that arose from our reliance on the plugin version compatibility tag for the public function get_global_unique_id. This function was actually introduced in WooCommerce version 9.2, but was incorrectly tagged as being available from version 9.1 onwards.
To ensure correct functionality, we have replaced the use of Compatibility::is_wc_version_gte() with method_exists(), which checks for the availability of specific public methods rather than relying on version numbers

Differential Revision: D68424348

* Update catalog link to navigate to correct tab in Commerce Manager (#2848)

* Update catalog link to navigate to correct tab in Commerce Manager

Co-authored-by: Marian Shymon <[email protected]>

---------

Co-authored-by: David Evbodaghe <[email protected]>
Co-authored-by: Marian Shymon <[email protected]>

* Fixed product url links (#2852)

* Fix - Removed the  "Sell on Instagram" checkbox from UX and cleaned up the backend (#2854)

* Removed the  Sell on Instagram UX and cleane dup the backend.

* Update php-unit-tests.yml to install SVN (#2859)

---------

Co-authored-by: Marian Shymon <[email protected]>
Co-authored-by: Halil Ozan Akgül <[email protected]>

* feat: Add custom fields to product data structure (#2836)

* feat: Add custom fields to product data structure

---------

Co-authored-by: David Evbodaghe <[email protected]>

* Fixed Category specific attributes related issues (#2860)

* Start `release/3.3.2`.

* updated the changelog and stable version

* Updated the current version

* Updated the WC supported version to 9.6

* Updated the stable version

---------

Co-authored-by: Halil Ozan Akgül <[email protected]>
Co-authored-by: vinkmeta <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: David Evbodaghe <[email protected]>
Co-authored-by: Marian Shymon <[email protected]>
Co-authored-by: Marian Shymon <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Vahid Kaykhaei <[email protected]>
Co-authored-by: vahidkay-meta <[email protected]>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Halil Ozan Akgül <[email protected]>
Co-authored-by: vinkmeta <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: David Evbodaghe <[email protected]>
Co-authored-by: Marian Shymon <[email protected]>
Co-authored-by: Marian Shymon <[email protected]>
@facebook-github-bot
fbshipit-source-id: bbb876a59dc530f663c5972aee5f492130b356d5
9763a1a
@vahidkay-meta
Fixed the formatting so it matches the internal repo
668aff0
@facebook-github-bot
fbshipit-source-id: 01c48061456e
e80749d
@vahidkay-meta
sync'ing the internal repo with GH main
08afb68
@facebook-github-bot
Expose Brand & MPN to Woocommerce UI (#2842)
f7a6c3b 
Summary:
Changes proposed in this Pull Request:

This PR introduces a new feature to the Facebook WooCommerce Plugin, allowing users to add a brand field to their products. With this update, we can seamlessly synchronize the brand field with the Facebook Commerce Manager platform.
<img width="679" alt="Screenshot 2025-01-10 at 18 57 18" src="https://github.com/user-attachments/assets/9d941a1f-48cb-4106-9672-1620aa926be6" />

<img width="527" alt="Screenshot 2024-10-30 at 18 08 36" src="https://github.com/user-attachments/assets/d0cf9ae0-293b-4685-a033-643dc6214a1f">

Pull Request resolved: #2842

Reviewed By: vinkmeta

Differential Revision: D68720240

Pulled By: devbodaghe

fbshipit-source-id: 0112d2063d9d9358c9f08efde51b6bf5d04b2d59
@facebook-github-bot
FBE: Use of recommended delete connection endpoint over delete permis…
4be2987 
…sion endpoint (#2844)

Summary:
### Changes proposed in this Pull Request:

**Problem:**

1. The Delete Permission User API only removed Meta connection assets from the WooCommerce database, leaving asset-related data enabled on Meta surfaces.
2. If a user disconnected the connection before uninstalling assets from Meta surfaces using Managed Connection; the UI for Managed Connection was also removed, making it difficult for users to uninstall this feature from Meta surface.

**Solution:**

1. Replaced the Delete Permission User API with the recommended Delete FBE Connection endpoint, which uninstalls assets from Meta surfaces and removes their permissions.
2. Removed the Managed Connection UI button for uninstalling FBE from Meta surfaces, as the Delete Connection endpoint now handles this functionality.

### Screenshots:

**Before:**

<img width="784" alt="image" src="https://github.com/user-attachments/assets/76bf6364-2af8-4657-a043-8e79aaff99c6">

**After:**

<img width="803" alt="image" src="https://github.com/user-attachments/assets/45e7ebc8-4a74-4589-a9e3-0e4fff1f4f20">

![Screenshot 2025-02-04 at 15 29 54](https://github.com/user-attachments/assets/77e02cba-ca89-42f9-a016-85c50e4b02fc)

<img width="797" alt="image" src="https://github.com/user-attachments/assets/f4d215b0-0959-4ee8-8347-16c64afe3460">

### Detailed test instructions:

1. Run new tests: `./vendor/bin/phpunit --filter test_delete_mbe_connection_deletes_user_permission_request`
2. Run all tests : `npm run test:php`
3. Lint: `./vendor/bin/phpcs`
4. Manual testing: I have tested new Disconnect UI flow; it uninstall FBE connection from WooCommerce as well as from Meta surface

### Changelog entry

- **Removed:** Delete Permission User API

- **Added:** Delete FBE Connection endpoint to uninstall assets from Meta surfaces and remove permissions

- **Removed:** Managed Connection UI button for uninstalling FBE from Meta surfaces (now handled by Delete Connection endpoint)

Pull Request resolved: #2844

Reviewed By: halilozanakgul

Differential Revision: D68972713

Pulled By: atuld123

fbshipit-source-id: b19ee8351b4852c69192449f9af2644960a55307
@github-actions
Start release/3.3.3.
0b3661d
@vahidkay-meta vahidkay-meta reopened this Feb 6, 2025
devbodaghe
devbodaghe approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@devbodaghe devbodaghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vahidkay-meta vahidkay-meta merged commit 50f5bb3 into trunk Feb 6, 2025
5 checks passed
@vahidkay-meta vahidkay-meta deleted the release/3.3.3 branch February 6, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devbodaghe devbodaghe devbodaghe approved these changes

@atuld123 atuld123 atuld123 approved these changes

@iodic iodic Awaiting requested review from iodic

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@devbodaghe @atuld123 @facebook-github-bot @vahidkay-meta @halilozanakgul @vinkmeta @mshymon