Fix deprecation warnings with PHP 8.2.

[rawdreeg]

Changes proposed in this Pull Request:

Fixes deprecation warnings with PHP 8.2 and above.

Closes #2635.

• Do the changed files pass phpcs checks? Please remove phpcs:ignore comments in changed files and fix any issues, or delete if not practical.

Detailed test instructions:

1. Enable debug and debug logging.
2. Activate and connect Facebook for WooCommerce
3. Navigate to Marketing > Facebook for WooCommerce. There should be no deprecation warnings.
4. Navigate to Tools > Scheduled Actions
5. Run the Pending wc_facebook_regenerate_feed action. There should be no deprecation warnings.

Changelog entry

Fix - Deprecation warnings with PHP 8.2.

[message-dimke]

I did some small research and when the changes in the PR are legit, I have a few questions:

https://github.com/woocommerce/facebook-for-woocommerce/blob/0ca17f88786cbb9180875d204058b65daf48d1f8/facebook-commerce.php#L1690-L1699

These lines do two things:

• First, they introduce another dynamic property, fbproductfeed.
• Second, this is the only place where WC_Facebook_Product_Feed is called with parameters.

My guess is, if looking at https://github.com/woocommerce/facebook-for-woocommerce/blob/0ca17f88786cbb9180875d204058b65daf48d1f8/includes/fbproductfeed.php#L44-L47, neither facebook_catalog_id nor feed_id are used anywhere. Search through the whole project did not provide any results. I believe we could remove those properties and even the constructor, unless there is a bug and we do need those properties somewhere.

[rawdreeg]

Your guess is right. These can be removed -- probably. these properties are set or accessed. I just didn't want to remove them without testing as I wasn't sure if I had missed anything

[rawdreeg]

@message-dimke I removed the unused constructor. 28a6844

[message-dimke]

LGTM, thank you, @rawdreeg !