Check if this is WooCommerce product before processing #2680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
changelog: fix
ibndawood
approved these changes
Jan 3, 2024
| @@ -315,7 +315,7 @@ public function __construct( WC_Facebookcommerce $facebook_for_woocommerce ) { | |||
|
|
|||
| add_action( 'add_meta_boxes', 'WooCommerce\Facebook\Admin\Product_Sync_Meta_Box::register', 10, 1 ); | |||
|
|
|||
| add_action( 'add_meta_boxes', [ $this, 'display_batch_api_completed' ], 10, 2 ); | |||
| add_action( 'add_meta_boxes_product', [ $this, 'display_batch_api_completed' ], 10, 2 ); | |||
There was a problem hiding this comment.
We should use add_meta_boxes_{$post_type} hook instead of add_meta_boxes . The order page triggers add_meta_boxes with screen_id and order instead of $post_type and $post.
| $fb_product_item_id = null; | ||
| $should_sync = true; | ||
| $no_sync_reason = ''; | ||
| public function display_batch_api_completed( $post ) { |
There was a problem hiding this comment.
add_meta_boxes_{$post_type} sends only the $post object:
https://github.com/WordPress/wordpress-develop/blob/87dfd5514b52aef456b7232b1959873e69e651da/src/wp-admin/includes/meta-boxes.php#L1731-L1731
|
There are two errors: When accessing from the edit page: When accessing from the edit order: I've pushed additional commit to fix the error triggered from edit order as well. |
|
Thanks folks, couldn't have seen this one coming. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Closes #2672 .
Check if we are dealing with WooCommerce product before processing.
phpcschecks? Please removephpcs:ignorecomments in changed files and fix any issues, or delete if not practical.Detailed test instructions:
I can't reproduce the 2672 so really hard to tell.
Changelog entry