-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(blog): Add author social icons for bluesky, mastodon, threads, twitch, youtube, instagram #10768
Open
GingerGeek
wants to merge
7
commits into
facebook:main
Choose a base branch
from
GingerGeek:additional-social-links
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+361
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
2 tasks
GingerGeek
force-pushed
the
additional-social-links
branch
3 times, most recently
from
December 14, 2024 20:39
d9e712d
to
e8fefe5
Compare
Add Icon and Handle support for: - Bluesky - Mastodon - Threads - Twitch - YouTube Includes Dogfooding page for testing
GingerGeek
force-pushed
the
additional-social-links
branch
from
December 14, 2024 21:08
e8fefe5
to
5a4bf80
Compare
slorber
changed the title
feat(content-blog,theme-classic) Add additional social media sites
feat(blog): Add author social icons for bluesky, mastodon, threads, twitch, youtube, instagram
Dec 26, 2024
slorber
approved these changes
Dec 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks
I took the opportunity to add instagram and fix minor issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
I wanted to include Bluesky and Threads in a Docusaurus site.
Add Icon and Handle support for:
Includes Dogfooding page for testing
Test Plan
Test links
Deploy preview: https://deploy-preview-10768--docusaurus-2.netlify.app
Dogfooding page: https://deploy-preview-10768--docusaurus-2.netlify.app/tests/blog
Related issues/PRs
#10764 - I had already started work on my PR when this was opened!