Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minerva-ag: Modify sensor name with prefix CB #2195

Closed
wants to merge 1 commit into from
Closed

minerva-ag: Modify sensor name with prefix CB #2195

wants to merge 1 commit into from

Conversation

LisaChang-Quanta
Copy link
Contributor

@LisaChang-Quanta LisaChang-Quanta commented Jan 21, 2025 •
edited
Loading

Summary:

  • Modify sensor name with prefix CB
  • Change MAX_AUX_SENSOR_NAME_LEN 42 -> 50
  • Adjust format string width based on MAX_AUX_SENSOR_NAME_LEN

Test Plan:

  • Build code: PASS

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 21, 2025
@facebook-github-bot
Copy link
Contributor

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. (Because this pull request was imported automatically, there will not be any future comments.)

jamesatha
jamesatha requested changes Jan 29, 2025
View reviewed changes
Copy link

@jamesatha jamesatha left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase as well

jamesatha
jamesatha requested changes Jan 29, 2025
View reviewed changes
meta-facebook/minerva-ag/src/shell/plat_perm_config_shell.c
@@ -36,7 +36,7 @@ static int cmd_perm_config_get(const struct shell *shell, size_t argc, char **ar
LOG_ERR("Can't find vr_rail_name by rail index: %x", i);
continue;
}
shell_print(shell, "[%2d]%-40s val=%d", i, rail_name,
shell_print(shell, "[%2d]%-50s val=%d", i, rail_name,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like we have a non-obvious connection between these format string widths and the MAX_AUX_SENSOR_NAME_LEN. Can we make that more explicit in all the places you updated to 50?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the comments to clarify the connection between the format string widths and MAX_AUX_SENSOR_NAME_LEN.

@LisaChang-Quanta LisaChang-Quanta force-pushed the minerva-ag/modify_sensor_name_with_prefix branch from d372414 to 3ed478f Compare February 3, 2025 06:13
@facebook-github-bot
Copy link
Contributor

@LisaChang-Quanta has updated the pull request. You must reimport the pull request before landing.

@LisaChang-Quanta LisaChang-Quanta force-pushed the minerva-ag/modify_sensor_name_with_prefix branch from 3ed478f to 0ac7067 Compare February 3, 2025 06:19
@facebook-github-bot
Copy link
Contributor

@LisaChang-Quanta has updated the pull request. You must reimport the pull request before landing.

amithash
amithash requested changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@amithash amithash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LisaChang-Quanta please rebase to main HEAD.

@LisaChang-Quanta
minerva-ag: Modify sensor name with prefix CB
4e0d041 
Summary:
- Modify sensor name with prefix CB
- Change MAX_AUX_SENSOR_NAME_LEN 42 -> 50
- Adjust format string width based on MAX_AUX_SENSOR_NAME_LEN

Test Plan:
- Build code: PASS
@LisaChang-Quanta LisaChang-Quanta force-pushed the minerva-ag/modify_sensor_name_with_prefix branch from 0ac7067 to 4e0d041 Compare February 7, 2025 02:50
@facebook-github-bot
Copy link
Contributor

@LisaChang-Quanta has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in deb9782.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amithash amithash amithash requested changes

@jamesatha jamesatha jamesatha requested changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LisaChang-Quanta @facebook-github-bot @amithash @jamesatha