Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minerva-ag: Modify voltage_peak commands #2184

Closed
wants to merge 1 commit into from
Closed

minerva-ag: Modify voltage_peak commands #2184

wants to merge 1 commit into from

Conversation

LisaChang-Quanta
Copy link
Contributor

Summary:

  • Modify voltage_peak commands with adding parameter hint
  • Delete plat_voltage_peak_shell.h file

Test Plan:

  • Build code: PASS

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 20, 2025
@facebook-github-bot
Copy link
Contributor

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. (Because this pull request was imported automatically, there will not be any future comments.)

@LisaChang-Quanta LisaChang-Quanta force-pushed the minerva-ag/modify_voltage_peak_commands branch from e12b30f to be2aed4 Compare January 21, 2025 11:58
@facebook-github-bot
Copy link
Contributor

@LisaChang-Quanta has updated the pull request. You must reimport the pull request before landing.

jamesatha
jamesatha requested changes Jan 30, 2025
View reviewed changes
Copy link

@jamesatha jamesatha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs to be rebased before we can approve

meta-facebook/minerva-ag/src/shell/plat_voltage_peak_shell.c Outdated
snprintf(rail_string, sizeof(rail_string), "%s", argv[1]);

if (strcmp(rail_string, "all") == 0) {
if (strcmp(argv[1], "all") == 0) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this should follow the style from above if it's being changed !strcmp

@LisaChang-Quanta LisaChang-Quanta force-pushed the minerva-ag/modify_voltage_peak_commands branch from be2aed4 to e1907eb Compare February 3, 2025 06:56
@facebook-github-bot
Copy link
Contributor

@LisaChang-Quanta has updated the pull request. You must reimport the pull request before landing.

@LisaChang-Quanta LisaChang-Quanta force-pushed the minerva-ag/modify_voltage_peak_commands branch from e1907eb to da5dab4 Compare February 3, 2025 07:01
@facebook-github-bot
Copy link
Contributor

@LisaChang-Quanta has updated the pull request. You must reimport the pull request before landing.

@LisaChang-Quanta LisaChang-Quanta force-pushed the minerva-ag/modify_voltage_peak_commands branch from da5dab4 to 060c51b Compare February 3, 2025 07:13
@facebook-github-bot
Copy link
Contributor

@LisaChang-Quanta has updated the pull request. You must reimport the pull request before landing.

@LisaChang-Quanta
minerva-ag: Modify voltage_peak commands
8cb0bda 
Summary:
- Modify voltage_peak commands with parameter hint
- Delete plat_voltage_peak_shell.h file

Test Plan:
- Build code: PASS
@LisaChang-Quanta LisaChang-Quanta force-pushed the minerva-ag/modify_voltage_peak_commands branch from 060c51b to 8cb0bda Compare February 3, 2025 07:30
@facebook-github-bot
Copy link
Contributor

@LisaChang-Quanta has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in d4d5f32.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesatha jamesatha jamesatha requested changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LisaChang-Quanta @facebook-github-bot @jamesatha