minerva-ag: Support soc_pcie_perst commands #2183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. (Because this pull request was imported automatically, there will not be any future comments.) |
jamesatha
requested changes
Jan 30, 2025
| static bool soc_pcie_perst_user_settings_init(void) | ||
| { | ||
| uint8_t setting_data = 0xFF; | ||
| if (get_user_settings_soc_pcie_perst_from_eeprom(&setting_data, sizeof(setting_data)) == |
There was a problem hiding this comment.
nit style: remove the == false and change the order of the if/else
| @@ -69,6 +69,19 @@ static int cmd_perm_config_get(const struct shell *shell, size_t argc, char **ar | |||
| } | |||
| } | |||
|
|
|||
| uint8_t setting_data_for_soc_pcie_perst = 0xFF; | |||
| if (get_user_settings_soc_pcie_perst_from_eeprom(&setting_data_for_soc_pcie_perst, | |||
Summary: - Support soc_pcie_perst commands Test Plan: - Build code: PASS
LisaChang-Quanta
force-pushed
the
minerva-ag/support_soc_pcie_perst_commands
branch
from
8eb23b8 to
24b9dc4
Compare
|
@LisaChang-Quanta has updated the pull request. You must reimport the pull request before landing. |
|
This pull request has been merged in f2b0bd5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Test Plan: