Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fby4: sd: support ina233 sensors #1487

Closed
wants to merge 1 commit into from

Conversation

EliHuang-wiwynn
Copy link
Contributor

Summary:
Description:

  • Add following sensors:
  • MB_INA233_x8_RTM_CURR_A
  • MB_INA233_x16_RTM_CURR_A
  • MB_INA233_x8_RTM_PWR_W
  • MB_INA233_x8_RTM_PWR_W

Motivation:

  • support sentinel dome ina233 sensor for retimer

Test Plan:

  • Get corresponding sensor reading

Test Log:
root@bmc:/usr/libexec/phosphor-state-manager# busctl introspect xyz.openbmc_project.PLDM /xyz/openbmc_project/sensors/current/MB_INA233_x16_RTM_CURR_A_70_134 ...
.Value property d 0.2569 emits-change writable
...
root@bmc:/usr/libexec/phosphor-state-manager# busctl introspect xyz.openbmc_project.PLDM /xyz/openbmc_project/sensors/current/MB_INA233_x8_RTM_CURR_A_69_134
...
.Value property d 0.186 emits-change writable
...
root@bmc:/usr/libexec/phosphor-state-manager# busctl introspect xyz.openbmc_project.PLDM /xyz/openbmc_project/sensors/power/MB_INA233_x16_RTM_PWR_W_99_134
...
.Value property d 3.075 emits-change writable
...
root@bmc:/usr/libexec/phosphor-state-manager# busctl introspect xyz.openbmc_project.PLDM /xyz/openbmc_project/sensors/power/MB_INA233_x8_RTM_PWR_W_98_134
...
.Value property d 2.25 emits-change writable
...

Summary:
Description:
- Add following sensors:
 - MB_INA233_x8_RTM_CURR_A
 - MB_INA233_x16_RTM_CURR_A
 - MB_INA233_x8_RTM_PWR_W
 - MB_INA233_x8_RTM_PWR_W

Motivation:
- support sentinel dome ina233 sensor for retimer

Test Plan:
- Get corresponding sensor reading

Test Log:
root@bmc:/usr/libexec/phosphor-state-manager# busctl introspect xyz.openbmc_project.PLDM /xyz/openbmc_project/sensors/current/MB_INA233_x16_RTM_CURR_A_70_134
...
.Value                                                property  d         0.2569                                   emits-change writable
...
root@bmc:/usr/libexec/phosphor-state-manager# busctl introspect xyz.openbmc_project.PLDM /xyz/openbmc_project/sensors/current/MB_INA233_x8_RTM_CURR_A_69_134
...
.Value                                                property  d         0.186                                    emits-change writable
...
root@bmc:/usr/libexec/phosphor-state-manager# busctl introspect xyz.openbmc_project.PLDM /xyz/openbmc_project/sensors/power/MB_INA233_x16_RTM_PWR_W_99_134
...
.Value                                                property  d         3.075                                    emits-change writable
...
root@bmc:/usr/libexec/phosphor-state-manager# busctl introspect xyz.openbmc_project.PLDM /xyz/openbmc_project/sensors/power/MB_INA233_x8_RTM_PWR_W_98_134
...
.Value                                                property  d         2.25                                     emits-change writable
...
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 29, 2023
@facebook-github-bot
Copy link
Contributor

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 9b81cd1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants