fby4: sd: support ssd temperature sensors #1485
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
There is a merge conflict in "plat_pldm_sensor.h" when push, could you update the PR to resolve the conflict? |
EricChen-wiwynn
force-pushed
the
231124-sd-nvme-temp
branch
from
bf7f39e to
8e8adc1
Compare
|
@EliHuang-wiwynn has updated the pull request. You must reimport the pull request before landing. |
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary:
Description:
- Add following sensors:
- MB_SSD_BOOT_TEMP_C
- MB_SSD_DATA_TEMP_C
Motivation:
- support ssd temperature sensors
Test Plan:
- Get corresponding sensor reading
Test Log:
root@bmc:/tmp# busctl introspect xyz.openbmc_project.PLDM /xyz/openbmc_project/sensors/temperature/MB_SSD_BOOT_TEMP_C_17_134
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
org.freedesktop.DBus.Introspectable interface - - -
.Introspect method - s -
org.freedesktop.DBus.Peer interface - - -
.GetMachineId method - s -
.Ping method - - -
org.freedesktop.DBus.Properties interface - - -
.Get method ss v -
.GetAll method s a{sv} -
.Set method ssv - -
.PropertiesChanged signal sa{sv}as - -
xyz.openbmc_project.Association.Definitions interface - - -
.Associations property a(sss) 1 "chassis" "all_sensors" "/xyz/openb... emits-change writable
xyz.openbmc_project.Sensor.Threshold.Critical interface - - -
.CriticalAlarmHigh property b false emits-change writable
.CriticalAlarmLow property b false emits-change writable
.CriticalHigh property d 77 emits-change writable
.CriticalLow property d 0 emits-change writable
.CriticalHighAlarmAsserted signal d - -
.CriticalHighAlarmDeasserted signal d - -
.CriticalLowAlarmAsserted signal d - -
.CriticalLowAlarmDeasserted signal d - -
xyz.openbmc_project.Sensor.Threshold.Warning interface - - -
.WarningAlarmHigh property b true emits-change writable
.WarningAlarmLow property b false emits-change writable
.WarningHigh property d 0 emits-change writable
.WarningLow property d 0 emits-change writable
.WarningHighAlarmAsserted signal d - -
.WarningHighAlarmDeasserted signal d - -
.WarningLowAlarmAsserted signal d - -
.WarningLowAlarmDeasserted signal d - -
xyz.openbmc_project.Sensor.Value interface - - -
.MaxValue property d 255 emits-change writable
.MinValue property d 0 emits-change writable
.Unit property s "xyz.openbmc_project.Sensor.Value.Uni... emits-change writable
.Value property d 41 emits-change writable
xyz.openbmc_project.State.Decorator.Availability interface - - -
.Available property b true emits-change writable
xyz.openbmc_project.State.Decorator.OperationalStatus interface - - -
.Functional property b true emits-change writable
root@bmc:/tmp# busctl introspect xyz.openbmc_project.PLDM /xyz/openbmc_project/sensors/temperature/MB_SSD_DATA_TEMP_C_18_134
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
org.freedesktop.DBus.Introspectable interface - - -
.Introspect method - s -
org.freedesktop.DBus.Peer interface - - -
.GetMachineId method - s -
.Ping method - - -
org.freedesktop.DBus.Properties interface - - -
.Get method ss v -
.GetAll method s a{sv} -
.Set method ssv - -
.PropertiesChanged signal sa{sv}as - -
xyz.openbmc_project.Association.Definitions interface - - -
.Associations property a(sss) 1 "chassis" "all_sensors" "/xyz/openb... emits-change writable
xyz.openbmc_project.Sensor.Threshold.Critical interface - - -
.CriticalAlarmHigh property b false emits-change writable
.CriticalAlarmLow property b false emits-change writable
.CriticalHigh property d 77 emits-change writable
.CriticalLow property d 0 emits-change writable
.CriticalHighAlarmAsserted signal d - -
.CriticalHighAlarmDeasserted signal d - -
.CriticalLowAlarmAsserted signal d - -
.CriticalLowAlarmDeasserted signal d - -
xyz.openbmc_project.Sensor.Threshold.Warning interface - - -
.WarningAlarmHigh property b true emits-change writable
.WarningAlarmLow property b false emits-change writable
.WarningHigh property d 0 emits-change writable
.WarningLow property d 0 emits-change writable
.WarningHighAlarmAsserted signal d - -
.WarningHighAlarmDeasserted signal d - -
.WarningLowAlarmAsserted signal d - -
.WarningLowAlarmDeasserted signal d - -
xyz.openbmc_project.Sensor.Value interface - - -
.MaxValue property d 255 emits-change writable
.MinValue property d 0 emits-change writable
.Unit property s "xyz.openbmc_project.Sensor.Value.Uni... emits-change writable
.Value property d 41 emits-change writable
xyz.openbmc_project.State.Decorator.Availability interface - - -
.Available property b true emits-change writable
xyz.openbmc_project.State.Decorator.OperationalStatus interface - - -
.Functional property b true emits-change writable
EricChen-wiwynn
force-pushed
the
231124-sd-nvme-temp
branch
from
8e8adc1 to
c454480
Compare
|
@EliHuang-wiwynn has updated the pull request. You must reimport the pull request before landing. |
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Rebased and conflicts has been solved, thank you for reviewing |
|
This pull request has been merged in af98c16. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Description:
Test Log:
root@bmc:/tmp# busctl introspect xyz.openbmc_project.PLDM /xyz/openbmc_project/sensors/temperature/MB_SSD_BOOT_TEMP_C_17_134
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
org.freedesktop.DBus.Introspectable interface - - -
.Introspect method - s -
org.freedesktop.DBus.Peer interface - - -
.GetMachineId method - s -
.Ping method - - -
org.freedesktop.DBus.Properties interface - - -
.Get method ss v -
.GetAll method s a{sv} -
.Set method ssv - -
.PropertiesChanged signal sa{sv}as - -
xyz.openbmc_project.Association.Definitions interface - - -
.Associations property a(sss) 1 "chassis" "all_sensors" "/xyz/openb... emits-change writable
xyz.openbmc_project.Sensor.Threshold.Critical interface - - -
.CriticalAlarmHigh property b false emits-change writable
.CriticalAlarmLow property b false emits-change writable
.CriticalHigh property d 77 emits-change writable
.CriticalLow property d 0 emits-change writable
.CriticalHighAlarmAsserted signal d - -
.CriticalHighAlarmDeasserted signal d - -
.CriticalLowAlarmAsserted signal d - -
.CriticalLowAlarmDeasserted signal d - -
xyz.openbmc_project.Sensor.Threshold.Warning interface - - -
.WarningAlarmHigh property b true emits-change writable
.WarningAlarmLow property b false emits-change writable
.WarningHigh property d 0 emits-change writable
.WarningLow property d 0 emits-change writable
.WarningHighAlarmAsserted signal d - -
.WarningHighAlarmDeasserted signal d - -
.WarningLowAlarmAsserted signal d - -
.WarningLowAlarmDeasserted signal d - -
xyz.openbmc_project.Sensor.Value interface - - -
.MaxValue property d 255 emits-change writable
.MinValue property d 0 emits-change writable
.Unit property s "xyz.openbmc_project.Sensor.Value.Uni... emits-change writable
.Value property d 41 emits-change writable
xyz.openbmc_project.State.Decorator.Availability interface - - -
.Available property b true emits-change writable
xyz.openbmc_project.State.Decorator.OperationalStatus interface - - -
.Functional property b true emits-change writable
root@bmc:/tmp# busctl introspect xyz.openbmc_project.PLDM /xyz/openbmc_project/sensors/temperature/MB_SSD_DATA_TEMP_C_18_134
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
org.freedesktop.DBus.Introspectable interface - - -
.Introspect method - s -
org.freedesktop.DBus.Peer interface - - -
.GetMachineId method - s -
.Ping method - - -
org.freedesktop.DBus.Properties interface - - -
.Get method ss v -
.GetAll method s a{sv} -
.Set method ssv - -
.PropertiesChanged signal sa{sv}as - -
xyz.openbmc_project.Association.Definitions interface - - -
.Associations property a(sss) 1 "chassis" "all_sensors" "/xyz/openb... emits-change writable
xyz.openbmc_project.Sensor.Threshold.Critical interface - - -
.CriticalAlarmHigh property b false emits-change writable
.CriticalAlarmLow property b false emits-change writable
.CriticalHigh property d 77 emits-change writable
.CriticalLow property d 0 emits-change writable
.CriticalHighAlarmAsserted signal d - -
.CriticalHighAlarmDeasserted signal d - -
.CriticalLowAlarmAsserted signal d - -
.CriticalLowAlarmDeasserted signal d - -
xyz.openbmc_project.Sensor.Threshold.Warning interface - - -
.WarningAlarmHigh property b true emits-change writable
.WarningAlarmLow property b false emits-change writable
.WarningHigh property d 0 emits-change writable
.WarningLow property d 0 emits-change writable
.WarningHighAlarmAsserted signal d - -
.WarningHighAlarmDeasserted signal d - -
.WarningLowAlarmAsserted signal d - -
.WarningLowAlarmDeasserted signal d - -
xyz.openbmc_project.Sensor.Value interface - - -
.MaxValue property d 255 emits-change writable
.MinValue property d 0 emits-change writable
.Unit property s "xyz.openbmc_project.Sensor.Value.Uni... emits-change writable
.Value property d 41 emits-change writable
xyz.openbmc_project.State.Decorator.Availability interface - - -
.Available property b true emits-change writable
xyz.openbmc_project.State.Decorator.OperationalStatus interface - - -
.Functional property b true emits-change writable