-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
common: Revise tmp461 for getting range of temperature detection #1479
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Description - Revise identification for tmp461 offset 0x3 by following datasheet Motivation -support CXL center temperature sensor on Floating Falls Test Plan: - Getting local temperature from device tmp461 Test Log: root@bmc:~# busctl introspect xyz.openbmc_project.PLDM /xyz/openbmc_project/sensors/temperature/FF_CXL_CNTR_TEMP_C_81_1 NAME TYPE SIGNATURE RESULT/VALUE FLAGS org.freedesktop.DBus.Introspectable interface - - - .Introspect method - s - org.freedesktop.DBus.Peer interface - - - .GetMachineId method - s - .Ping method - - - org.freedesktop.DBus.Properties interface - - - .Get method ss v - .GetAll method s a{sv} - .Set method ssv - - .PropertiesChanged signal sa{sv}as - - xyz.openbmc_project.Association.Definitions interface - - - .Associations property a(sss) 1 "chassis" "all_sensors" "/xyz/openb... emits-change writable xyz.openbmc_project.Sensor.Threshold.Critical interface - - - .CriticalAlarmHigh property b true emits-change writable .CriticalAlarmLow property b true emits-change writable .CriticalHigh property d 0 emits-change writable .CriticalLow property d 84 emits-change writable .CriticalHighAlarmAsserted signal d - - .CriticalHighAlarmDeasserted signal d - - .CriticalLowAlarmAsserted signal d - - .CriticalLowAlarmDeasserted signal d - - xyz.openbmc_project.Sensor.Threshold.Warning interface - - - .WarningAlarmHigh property b true emits-change writable .WarningAlarmLow property b false emits-change writable .WarningHigh property d 0 emits-change writable .WarningLow property d 0 emits-change writable .WarningHighAlarmAsserted signal d - - .WarningHighAlarmDeasserted signal d - - .WarningLowAlarmAsserted signal d - - .WarningLowAlarmDeasserted signal d - - xyz.openbmc_project.Sensor.Value interface - - - .MaxValue property d 255 emits-change writable .MinValue property d 0 emits-change writable .Unit property s "xyz.openbmc_project.Sensor.Value.Uni... emits-change writable .Value property d 45 emits-change writable xyz.openbmc_project.State.Decorator.Availability interface - - - .Available property b true emits-change writable xyz.openbmc_project.State.Decorator.OperationalStatus interface - - - .Functional property b true emits-change writable
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request has been merged in 4f4eaae. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Description
Motivation
-support CXL center temperature sensor on Floating Falls
Test Plan:
Test Log:
root@bmc:~# busctl introspect xyz.openbmc_project.PLDM /xyz/openbmc_project/sensors/temperature/FF_CXL_CNTR_TEMP_C_81_1
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
org.freedesktop.DBus.Introspectable interface - - -
.Introspect method - s -
org.freedesktop.DBus.Peer interface - - -
.GetMachineId method - s -
.Ping method - - -
org.freedesktop.DBus.Properties interface - - -
.Get method ss v -
.GetAll method s a{sv} -
.Set method ssv - -
.PropertiesChanged signal sa{sv}as - -
xyz.openbmc_project.Association.Definitions interface - - -
.Associations property a(sss) 1 "chassis" "all_sensors" "/xyz/openb... emits-change writable
xyz.openbmc_project.Sensor.Threshold.Critical interface - - -
.CriticalAlarmHigh property b true emits-change writable
.CriticalAlarmLow property b true emits-change writable
.CriticalHigh property d 0 emits-change writable
.CriticalLow property d 84 emits-change writable
.CriticalHighAlarmAsserted signal d - -
.CriticalHighAlarmDeasserted signal d - -
.CriticalLowAlarmAsserted signal d - -
.CriticalLowAlarmDeasserted signal d - -
xyz.openbmc_project.Sensor.Threshold.Warning interface - - -
.WarningAlarmHigh property b true emits-change writable
.WarningAlarmLow property b false emits-change writable
.WarningHigh property d 0 emits-change writable
.WarningLow property d 0 emits-change writable
.WarningHighAlarmAsserted signal d - -
.WarningHighAlarmDeasserted signal d - -
.WarningLowAlarmAsserted signal d - -
.WarningLowAlarmDeasserted signal d - -
xyz.openbmc_project.Sensor.Value interface - - -
.MaxValue property d 255 emits-change writable
.MinValue property d 0 emits-change writable
.Unit property s "xyz.openbmc_project.Sensor.Value.Uni... emits-change writable
.Value property d 45 emits-change writable
xyz.openbmc_project.State.Decorator.Availability interface - - -
.Available property b true emits-change writable
xyz.openbmc_project.State.Decorator.OperationalStatus interface - - -
.Functional property b true emits-change writable