Skip to content

Commit

Permalink
GT: Fix ADC sensor reading issue and adjust threshold
Browse files Browse the repository at this point in the history
Summary:
- The NIC7 init arguments are missing in the ina230_nic_sensor_init_args table, and the memory offset for ina230_pex_p1v25_sensor_init_args is positioned just behind it. As a result, the is_init value of PEX0 1V25 is set to true in advance, causing the PEX0 1V25 ADC to be skipped during driver initialization.

- Add NIC7 init arguments in ina230_nic_sensor_init_args table.

- Previously, the INA230 alert interrupt threshold was set to 18W, while the ISL28022 threshold remained at its default value of 65.28V. Since the ISL28022 only allows setting voltage as the interrupt threshold, we've changed the INA230 interrupt threshold to voltage. We'd also discussed and adjusted the threshold values with the EE team.

- The new INA230 thresholds are as follows:
> - NIC: 13.2V
> - PEX_1V25: 1.32V
> - PEX_1V8: 2V
> - SSD: 13.2V

- However, due to the ISL28022 threshold LSB is 256mV, we weren't able to set it to the values mentioned above. Instead, we've chosen the closest and greater values for ISL28022:
> - NIC: 13.312V
> - PEX_1V25: 1.536V
> - PEX_1V8: 2.048V
> - SSD: 13.312V

Test Plan:
- Build code: Pass
  • Loading branch information
Victor-Jhong committed Nov 29, 2023
1 parent 2cc2f0d commit 15323db
Showing 1 changed file with 131 additions and 56 deletions.
Loading

0 comments on commit 15323db

Please sign in to comment.