Use MockDevice.cpp when building navy, move code within #ifdefn in FDP Device tests #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add MockDevice.cpp to navy build
facebook-github-bot
added
the
CLA Signed
|
@pbhandar2 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@pbhandar2 merged this pull request in 193325b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses two build failures in the CacheLib repository:
Navy library MockDevice integration
The navy library recently started using MockDevice, but the build was failing due to missing API calls. This was caused by MockDevice.cpp not being included in the build process, and gmock not being linked.
Changes made:
Added MockDevice.cpp to the build process for navy
Linked gmock library to resolve missing API calls
FDP code test
Some variables used in FDP tests were not defined because they were contained with code blocks accessable only when FDP flags were set.
Changes made:
Move the FDP test code within #ifdefn block