Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete not_none #3003

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Delete not_none #3003

wants to merge 2 commits into from

Conversation

mpolson64
Copy link
Contributor

Summary: As titled

Reviewed By: saitcakmak, Balandat, paschai

Differential Revision: D65278088

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 31, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65278088

mpolson64 added a commit to mpolson64/Ax that referenced this pull request Oct 31, 2024
Summary:
Pull Request resolved: facebook#3003

As titled

Reviewed By: saitcakmak, Balandat, paschai

Differential Revision: D65278088
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65278088

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65278088

mpolson64 added a commit to mpolson64/Ax that referenced this pull request Oct 31, 2024
Summary:
Pull Request resolved: facebook#3003

As titled

Reviewed By: saitcakmak, Balandat, paschai

Differential Revision: D65278088
mpolson64 added a commit to mpolson64/Ax that referenced this pull request Oct 31, 2024
Summary:
Pull Request resolved: facebook#3003

As titled

Reviewed By: saitcakmak, Balandat, paschai

Differential Revision: D65278088
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65278088

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 96.81698% with 12 lines in your changes missing coverage. Please review.

Project coverage is 95.61%. Comparing base (a9a9a7c) to head (128ffe3).

Files with missing lines Patch % Lines
ax/core/parameter.py 85.71% 2 Missing ⚠️
ax/core/experiment.py 85.71% 1 Missing ⚠️
ax/modelbridge/base.py 75.00% 1 Missing ⚠️
ax/modelbridge/modelbridge_utils.py 50.00% 1 Missing ⚠️
ax/plot/diagnostic.py 50.00% 1 Missing ⚠️
ax/plot/helper.py 66.66% 1 Missing ⚠️
ax/plot/pareto_frontier.py 80.00% 1 Missing ⚠️
ax/plot/slice.py 66.66% 1 Missing ⚠️
ax/plot/trace.py 50.00% 1 Missing ⚠️
ax/service/utils/best_point_mixin.py 90.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3003   +/-   ##
=======================================
  Coverage   95.60%   95.61%           
=======================================
  Files         485      485           
  Lines       48978    49005   +27     
=======================================
+ Hits        46827    46854   +27     
  Misses       2151     2151           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mpolson64 and others added 2 commits October 31, 2024 13:33
Differential Revision: D65275698
Summary:
Pull Request resolved: facebook#3003

As titled

Reviewed By: saitcakmak, Balandat, paschai

Differential Revision: D65278088
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65278088

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants