Get rid of SurrogateRunner and SurrogateBenchmarkProblem #2988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65139431 |
esantorella
force-pushed
the
export-D65139431
branch
from
317e52f
to
fa7f898
Compare
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Oct 29, 2024
Summary: Context: * `SurrogateRunner` and `SurrogateBenchmarkProblem` are unused as of D64855010. See that diff for further context. Changes in this diff: * Remove `SurrogateRunner` * Remove `SurrogateBenchmarkProblem` * Remove corresponding tests (all functionality is covered by new tests, e.g. for `SurrogateTestFunction`) Reviewed By: Balandat Differential Revision: D65139431
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Oct 29, 2024
Summary: Context: * `SurrogateRunner` and `SurrogateBenchmarkProblem` are unused as of D64855010. See that diff for further context. Changes in this diff: * Remove `SurrogateRunner` * Remove `SurrogateBenchmarkProblem` * Remove corresponding tests (all functionality is covered by new tests, e.g. for `SurrogateTestFunction`) Reviewed By: Balandat Differential Revision: D65139431
|
This pull request was exported from Phabricator. Differential Revision: D65139431 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2988 +/- ##
========================================
Coverage 95.59% 95.59%
========================================
Files 487 486 -1
Lines 49108 48996 -112
========================================
- Hits 46943 46838 -105
+ Misses 2165 2158 -7 ☔ View full report in Codecov by Sentry. |
Summary: Context: * `SurrogateRunner` and `SurrogateBenchmarkProblem` are unused as of D64855010. See that diff for further context. Changes in this diff: * Remove `SurrogateRunner` * Remove `SurrogateBenchmarkProblem` * Remove corresponding tests (all functionality is covered by new tests, e.g. for `SurrogateTestFunction`) Reviewed By: Balandat Differential Revision: D65139431
esantorella
force-pushed
the
export-D65139431
branch
from
fa7f898
to
14dc9e2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65139431 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Oct 30, 2024
Summary: Context: * `SurrogateRunner` and `SurrogateBenchmarkProblem` are unused as of D64855010. See that diff for further context. Changes in this diff: * Remove `SurrogateRunner` * Remove `SurrogateBenchmarkProblem` * Remove corresponding tests (all functionality is covered by new tests, e.g. for `SurrogateTestFunction`) Reviewed By: Balandat Differential Revision: D65139431
|
This pull request has been merged in 9afec01. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context:
SurrogateRunnerandSurrogateBenchmarkProblemare unused as of D64855010. See that diff for further context.Changes in this diff:
SurrogateRunnerSurrogateBenchmarkProblemSurrogateTestFunction)Reviewed By: Balandat
Differential Revision: D65139431