Add potential SQL deprecation warning at Encoder instantiation time #2974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64781681 |
…acebook#2974) Summary: We are considering deprecating SQLAlchechemy support in Ax due in large part to a perceived lack of usage by our OSS community. If you are using this feature please let us know as soon as possible via Github Issues. Reviewed By: lena-kashtelyan Differential Revision: D64781681
mpolson64
force-pushed
the
export-D64781681
branch
from
459f35a
to
046322c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64781681 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2974 +/- ##
=======================================
Coverage 95.65% 95.65%
=======================================
Files 486 486
Lines 48907 48908 +1
=======================================
+ Hits 46783 46784 +1
Misses 2124 2124 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 41da8f6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: We are considering deprecating SQLAlchechemy support in Ax due in large part to a perceived lack of usage by our OSS community. If you are using this feature please let us know as soon as possible via Github Issues.
Reviewed By: lena-kashtelyan
Differential Revision: D64781681