Use optimize_acqf_mixed_alternating in Acquisition.optimize
#2972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This diff updates `Acquisition.optimize` to utilize `optimize_acqf_mixed_alternating` when - there are no categorical features (except for those handled by transforms), - all ordinal features are integer valued, - and there are more than `ALTERNATING_OPTIMIZER_THRESHOLD` combinations of discrete choices. `optimize_acqf_mixed_alternating` will be more efficient than `optimize_acqf_mixed` when there are many combinations of discrete choices. The other conditions are current limitations of the optimizer. The current choice of `ALTERNATING_OPTIMIZER_THRESHOLD = 10` is somewhat arbitrary. Reviewed By: susanxia1006 Differential Revision: D65066344
|
This pull request was exported from Phabricator. Differential Revision: D65066344 |
facebook-github-bot
added
CLA Signed
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Oct 28, 2024
…book#2972) Summary: This diff updates `Acquisition.optimize` to utilize `optimize_acqf_mixed_alternating` when - there are no categorical features (except for those handled by transforms), - all ordinal features are integer valued, - and there are more than `ALTERNATING_OPTIMIZER_THRESHOLD` combinations of discrete choices. `optimize_acqf_mixed_alternating` will be more efficient than `optimize_acqf_mixed` when there are many combinations of discrete choices. The other conditions are current limitations of the optimizer. The current choice of `ALTERNATING_OPTIMIZER_THRESHOLD = 10` is somewhat arbitrary. Reviewed By: susanxia1006 Differential Revision: D65066344
|
This pull request has been merged in d1e65c5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff updates
Acquisition.optimizeto utilizeoptimize_acqf_mixed_alternatingwhenALTERNATING_OPTIMIZER_THRESHOLDcombinations of discrete choices.optimize_acqf_mixed_alternatingwill be more efficient thanoptimize_acqf_mixedwhen there are many combinations of discrete choices. The other conditions are current limitations of the optimizer.The current choice of
ALTERNATING_OPTIMIZER_THRESHOLD = 10is somewhat arbitrary.Reviewed By: susanxia1006
Differential Revision: D65066344