-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce trial_indices argument to SupervisedDataset #2960
Open
bernardbeckerman
wants to merge
1
commit into
facebook:main
Choose a base branch
from
bernardbeckerman:export-D64764019
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Do not delete this pull request or issue due to inactivity.
label
Oct 24, 2024
This pull request was exported from Phabricator. Differential Revision: D64764019 |
bernardbeckerman
force-pushed
the
export-D64764019
branch
from
October 25, 2024 00:40
61920de
to
5192de2
Compare
bernardbeckerman
pushed a commit
to bernardbeckerman/Ax
that referenced
this pull request
Oct 25, 2024
Summary: X-link: pytorch/botorch#2595 Adds optional `trial_indices` to SupervisedDataset, whose dimensionality should correspond 1:1 with the first few dimensions of X and Y tensors, as validated in `_validate` ([pointer](https://www.internalfb.com/diff/D64764019?permalink=1739375523489084)). Reviewed By: Balandat Differential Revision: D64764019
This pull request was exported from Phabricator. Differential Revision: D64764019 |
bernardbeckerman
pushed a commit
to bernardbeckerman/botorch
that referenced
this pull request
Oct 25, 2024
Summary: X-link: facebook/Ax#2960 Adds optional `trial_indices` to SupervisedDataset, whose dimensionality should correspond 1:1 with the first few dimensions of X and Y tensors, as validated in `_validate` ([pointer](https://www.internalfb.com/diff/D64764019?permalink=1739375523489084)). Reviewed By: Balandat Differential Revision: D64764019
bernardbeckerman
pushed a commit
to bernardbeckerman/botorch
that referenced
this pull request
Oct 25, 2024
Summary: X-link: facebook/Ax#2960 Adds optional `trial_indices` to SupervisedDataset, whose dimensionality should correspond 1:1 with the first few dimensions of X and Y tensors, as validated in `_validate` ([pointer](https://www.internalfb.com/diff/D64764019?permalink=1739375523489084)). Reviewed By: Balandat Differential Revision: D64764019
bernardbeckerman
pushed a commit
to bernardbeckerman/Ax
that referenced
this pull request
Oct 25, 2024
Summary: X-link: pytorch/botorch#2595 Adds optional `trial_indices` to SupervisedDataset, whose dimensionality should correspond 1:1 with the first few dimensions of X and Y tensors, as validated in `_validate` ([pointer](https://www.internalfb.com/diff/D64764019?permalink=1739375523489084)). Reviewed By: Balandat Differential Revision: D64764019
bernardbeckerman
force-pushed
the
export-D64764019
branch
from
October 25, 2024 01:29
5192de2
to
676a263
Compare
This pull request was exported from Phabricator. Differential Revision: D64764019 |
bernardbeckerman
pushed a commit
to bernardbeckerman/Ax
that referenced
this pull request
Oct 25, 2024
Summary: X-link: pytorch/botorch#2595 Adds optional `trial_indices` to SupervisedDataset, whose dimensionality should correspond 1:1 with the first few dimensions of X and Y tensors, as validated in `_validate` ([pointer](https://www.internalfb.com/diff/D64764019?permalink=1739375523489084)). Reviewed By: Balandat Differential Revision: D64764019
bernardbeckerman
force-pushed
the
export-D64764019
branch
from
October 25, 2024 01:32
676a263
to
7c75ef9
Compare
This pull request was exported from Phabricator. Differential Revision: D64764019 |
bernardbeckerman
pushed a commit
to bernardbeckerman/botorch
that referenced
this pull request
Oct 25, 2024
Summary: X-link: facebook/Ax#2960 Adds optional `trial_indices` to SupervisedDataset, whose dimensionality should correspond 1:1 with the first few dimensions of X and Y tensors, as validated in `_validate` ([pointer](https://www.internalfb.com/diff/D64764019?permalink=1739375523489084)). Reviewed By: Balandat Differential Revision: D64764019
bernardbeckerman
pushed a commit
to bernardbeckerman/botorch
that referenced
this pull request
Oct 25, 2024
Summary: X-link: facebook/Ax#2960 Adds optional `trial_indices` to SupervisedDataset, whose dimensionality should correspond 1:1 with the first few dimensions of X and Y tensors, as validated in `_validate` ([pointer](https://www.internalfb.com/diff/D64764019?permalink=1739375523489084)). Reviewed By: Balandat Differential Revision: D64764019
Summary: X-link: pytorch/botorch#2595 Adds optional `trial_indices` to SupervisedDataset, whose dimensionality should correspond 1:1 with the first few dimensions of X and Y tensors, as validated in `_validate` ([pointer](https://www.internalfb.com/diff/D64764019?permalink=1739375523489084)). Reviewed By: Balandat Differential Revision: D64764019
bernardbeckerman
force-pushed
the
export-D64764019
branch
from
October 25, 2024 02:05
7c75ef9
to
b87c949
Compare
This pull request was exported from Phabricator. Differential Revision: D64764019 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Adds optional
trial_indices
to SupervisedDataset, whose dimensionality should correspond 1:1 with the first few dimensions of X and Y tensors, as validated in_validate
(pointer).Differential Revision: D64764019