Use "observed" in copy and adopt nudge in insample cards #2958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64605408 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2958 +/- ##
=======================================
Coverage 95.65% 95.65%
=======================================
Files 486 486
Lines 48789 48796 +7
=======================================
+ Hits 46669 46676 +7
Misses 2120 2120 ☔ View full report in Codecov by Sentry. |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Oct 24, 2024
Summary: We're using observed to be consistent with the scatter plot https://fburl.com/code/ammcq511. Bumps: - +1 for being modeled - +2 for being an objective - +1 for being a constraint - - up to 9 for being an old trial, by index - on the experiment, we want newer trials first. Differential Revision: D64605408
danielcohenlive
force-pushed
the
export-D64605408
branch
from
543243b
to
82a881c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64605408 |
Summary: We're using observed to be consistent with the scatter plot https://fburl.com/code/ammcq511. Bumps: - +1 for being modeled - +2 for being an objective - +1 for being a constraint - - up to 9 for being an old trial, by index - on the experiment, we want newer trials first. Reviewed By: ItsMrLin Differential Revision: D64605408
danielcohenlive
force-pushed
the
export-D64605408
branch
from
82a881c
to
9062923
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64605408 |
|
This pull request has been merged in cda1b82. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We're using observed to be consistent with the scatter plot https://fburl.com/code/ammcq511.
Bumps:
Differential Revision: D64605408