Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redo constraint violation indicators and legend on inample and predicted plots #2955

Closed
wants to merge 1 commit into from
Closed

Redo constraint violation indicators and legend on inample and predicted plots #2955

wants to merge 1 commit into from

Commits on Oct 25, 2024

  1. Redo constraint violation indicators and legend on insample and predi… 

    …cted plots (facebook#2955)

Summary:

Instead of varying sizing, we're adding a red outline of varying opacity based on the overall probability of constraint violation.

There is a hack to make sure the outlines don't appear in the legend, as the legend normally reflects the first point in each group.  We're hiding the original and creating a duplicate group of the same name at point (None, None).  In doing this, we give up the ability to toggle points on and off the graph by clicking on their legend item, which I just discovered existed.

{F1944580069}

Reviewed By: ItsMrLin

Differential Revision: D64850289
    @facebook-github-bot
    Daniel Cohen authored and facebook-github-bot committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    59237ad View commit details
    Browse the repository at this point in the history