allow candidate_generator_function to stop interactive_optimize
#2950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64883803 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2950 +/- ##
=======================================
Coverage 95.64% 95.65%
=======================================
Files 486 486
Lines 48871 48881 +10
=======================================
+ Hits 46745 46755 +10
Misses 2126 2126 ☔ View full report in Codecov by Sentry. |
Summary: Allowing `interactive_optimize` to be stopped from the candidate generation function. When the candidate generator keeps throwing exception, we don't have a good way to stop the loop and the method may hang at `candidate_queue.get()`. This prevent us from handling failing candidate_generator gracefully even if we wish to. meta: see how it is being used to fix time-out `test_play_preference_game` in D64883802 Reviewed By: Balandat Differential Revision: D64883803
ItsMrLin
force-pushed
the
export-D64883803
branch
from
eda7b33
to
b61ead8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64883803 |
|
This pull request has been merged in 0442f2d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D64883803