Clean up force_use_optimize_acqf argument from Acquisition.optimize
#2942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64840442 |
…function from Acquisition.optimize (facebook#2942) Summary: These were experimental options added to support straight through gradient estimators, which wasn't used and has been removed. This diff cleans up special argument handling for `force_use_optimize_acqf` and custom `post_processing_function`. Differential Revision: D64840442
saitcakmak
force-pushed
the
export-D64840442
branch
from
f4f13fe
to
1d452b0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64840442 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2942 +/- ##
==========================================
- Coverage 95.68% 95.68% -0.01%
==========================================
Files 504 504
Lines 49567 49530 -37
==========================================
- Hits 47429 47392 -37
Misses 2138 2138 ☔ View full report in Codecov by Sentry. |
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Oct 23, 2024
…function from Acquisition.optimize (facebook#2942) Summary: These were experimental options added to support straight through gradient estimators, which wasn't used and has been removed. This diff cleans up special argument handling for `force_use_optimize_acqf` and custom `post_processing_function`. Reviewed By: sdaulton Differential Revision: D64840442
|
This pull request has been merged in cf194f3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This was an experimental option added to support straight through gradient estimators, which wasn't used and has been removed. This diff cleans up special argument handling for
force_use_optimize_acqf.Differential Revision: D64840442