Add Sequential high-d GS tests with new test harness #2940
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64807079 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2940 +/- ##
=======================================
Coverage 95.68% 95.68%
=======================================
Files 504 504
Lines 49567 49568 +1
=======================================
+ Hits 47429 47430 +1
Misses 2138 2138 ☔ View full report in Codecov by Sentry. |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Oct 23, 2024
Summary: Lena recently added a test harness which will allow us to quickly test a variety of GS configurations at the GS level, previously we were testing them at the client level, but this is a bit higher than we may always access the stack so it's good to have both sets of tests. This diff adds tests for high-d seq gs: - tests that high-d seq works as expected and gens - also tests that experiment_properties if n and arms per node is none Follow up diffs will test: - quickbo gs - ebashr fixes that came to light during bug bash - multi-task models Reviewed By: lena-kashtelyan Differential Revision: D64807079
mgarrard
force-pushed
the
export-D64807079
branch
from
78fc854
to
faad6fa
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64807079 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Oct 23, 2024
Summary: Lena recently added a test harness which will allow us to quickly test a variety of GS configurations at the GS level, previously we were testing them at the client level, but this is a bit higher than we may always access the stack so it's good to have both sets of tests. This diff adds tests for high-d seq gs: - tests that high-d seq works as expected and gens - also tests that experiment_properties if n and arms per node is none Follow up diffs will test: - quickbo gs - ebashr fixes that came to light during bug bash - multi-task models Reviewed By: lena-kashtelyan Differential Revision: D64807079
mgarrard
force-pushed
the
export-D64807079
branch
from
faad6fa
to
be80975
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64807079 |
Summary: Lena recently added a test harness which will allow us to quickly test a variety of GS configurations at the GS level, previously we were testing them at the client level, but this is a bit higher than we may always access the stack so it's good to have both sets of tests. This diff adds tests for high-d seq gs: - tests that high-d seq works as expected and gens - also tests that experiment_properties if n and arms per node is none Follow up diffs will test: - quickbo gs - ebashr fixes that came to light during bug bash - multi-task models Reviewed By: lena-kashtelyan Differential Revision: D64807079
mgarrard
force-pushed
the
export-D64807079
branch
from
be80975
to
dda2465
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64807079 |
|
This pull request has been merged in 5c7ccb5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Lena recently added a test harness which will allow us to quickly test a variety of GS configurations at the GS level, previously we were testing them at the client level, but this is a bit higher than we may always access the stack so it's good to have both sets of tests.
This diff adds tests for high-d seq gs:
Follow up diffs will test:
Differential Revision: D64807079