Support MultiTypeExperiment/RealtimeExperiment in Instantiation #2939
+273
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64612495 |
|
This pull request was exported from Phabricator. Differential Revision: D64612495 |
andycylmeta
force-pushed
the
export-D64612495
branch
from
7d591f8
to
b9192db
Compare
andycylmeta
added a commit
to andycylmeta/Ax
that referenced
this pull request
Nov 1, 2024
Summary: Pull Request resolved: facebook#2939 1. **InstatntiationBase:** Add support returning MultiTypeExperiment in InstatntiationBase._make_experiment. 2. **MultiTypeExperiment:** Add add_tracking_metrics function in MultiTypeExperiment to support batch adding metrics when creating a MultiTypeExperiment. 3. **AxClient**: Add support for creating MultiTypeExperiment, add_trial_type and add_tracking_metrics. Reviewed By: sdaulton Differential Revision: D64612495
Summary: Pull Request resolved: facebook#2939 1. **InstatntiationBase:** Add support returning MultiTypeExperiment in InstatntiationBase._make_experiment. 2. **MultiTypeExperiment:** Add add_tracking_metrics function in MultiTypeExperiment to support batch adding metrics when creating a MultiTypeExperiment. 3. **AxClient**: Add support for creating MultiTypeExperiment, add_trial_type and add_tracking_metrics. Reviewed By: sdaulton Differential Revision: D64612495
|
This pull request was exported from Phabricator. Differential Revision: D64612495 |
andycylmeta
force-pushed
the
export-D64612495
branch
from
b9192db
to
e5d25df
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2939 +/- ##
=======================================
Coverage 95.60% 95.60%
=======================================
Files 483 483
Lines 48942 48988 +46
=======================================
+ Hits 46793 46837 +44
- Misses 2149 2151 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Differential Revision: D64612495