Add checks that only Range parameters can have ParameterConstraints instantiated #2936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64784254 |
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Oct 23, 2024
…nstantiated (facebook#2936) Summary: As titled. This is a little janky but will do for now, a clearner validation scheme will be set up with via the Ax API workstream. Differential Revision: D64784254
mpolson64
force-pushed
the
export-D64784254
branch
from
3d558ea
to
4d99a93
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64784254 |
…nstantiated (facebook#2936) Summary: As titled. This is a little janky but will do for now, a clearner validation scheme will be set up with via the Ax API workstream. Differential Revision: D64784254
mpolson64
force-pushed
the
export-D64784254
branch
from
4d99a93
to
7fbda57
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64784254 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2936 +/- ##
==========================================
- Coverage 95.68% 95.67% -0.01%
==========================================
Files 504 504
Lines 49550 49554 +4
==========================================
+ Hits 47410 47412 +2
- Misses 2140 2142 +2 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 322ea96. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As titled. This is a little janky but will do for now, a clearner validation scheme will be set up with via the Ax API workstream.
Differential Revision: D64784254