Remove custom axis labels for CrossValidation Plot #2917
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Display title and subtitle, and sort cards by level in display_cards. Useful for using with AxClient in a notebook. Also add minimum_priority argument to display_cards, by default show everything but debug Reviewed By: danielcohenlive Differential Revision: D64495780
…ook#2898) Summary: Bugfix. If an arm does not have a value for its metric it will fail to plot. Noticed this while working on something else Reviewed By: danielcohenlive Differential Revision: D64496771
Summary:
Instead of having "Observed {metric_name}" just show "observed" (and same for predicted). In plots where the metric name is long the custom labels were unweildy. {F1937529521}
This should not be a regression to UX since D64495780 makes the title and subtitle get displayed in bento as well.
Reviewed By: danielcohenlive
Differential Revision: D64609346
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64609346 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2917 +/- ##
==========================================
- Coverage 95.67% 95.66% -0.01%
==========================================
Files 502 502
Lines 49532 49535 +3
==========================================
Hits 47390 47390
- Misses 2142 2145 +3 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 168932b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Instead of having "Observed {metric_name}" just show "observed" (and same for predicted). In plots where the metric name is long the custom labels were unweildy. {F1937529521}
This should not be a regression to UX since D64495780 makes the title and subtitle get displayed in bento as well.
Reviewed By: danielcohenlive
Differential Revision: D64609346