Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support(?) for multiple surrogates from Acquisition #2916

Closed
wants to merge 1 commit into from
Closed

Remove support(?) for multiple surrogates from Acquisition #2916

wants to merge 1 commit into from

Commits on Oct 18, 2024

  1. Remove support(?) for multiple surrogates from Acquisition (facebook#… 

    …2916)

Summary:

The current implementation of `Acqusition.__init__` technically supports multiple surrogates. It combines the models from each surrogate into a `ModelDict` before passing them down to acquisition input constructors. `ModelDict` was added some time ago with the goal of using it to support failure aware BO, but those methods never got implemented and there is no current use case that supports it.

In its current form, the support for multiple surrugates is completely superficial and does not bring much value. It requires complex handling of arguments like `X_pending` and `X_observed`, which itself comes with TODOs to fix or improve it.

This diff removes support for multiple surrogates from `Acquisition` and cleans up some of the complicated argument handling that was necessitated by it. If we decide to support multiple surrogates again at a later date, we can do so with a better thought out design and implement it more cleanly.

Differential Revision: D64610244
    @saitcakmak @facebook-github-bot
    saitcakmak authored and facebook-github-bot committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    aaa8bb2 View commit details
    Browse the repository at this point in the history