Fix pending point extraction in gen_multi_from_multi #2914
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64563496 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Oct 17, 2024
Summary: Earlier today danielcohenlive was having trouble using gs and was getting a weird modeling error. Lena did some investigation an found we were using the wrong method to grab pending points from the experiment. See her notebook in the test plan for more details. to quote "Basically in some settings it’s not safe to deem a point pending based on the trial status; generally no point for which we have data, we want to consider pending" I just am putting up the fix with her logic here Differential Revision: D64563496
mgarrard
force-pushed
the
export-D64563496
branch
from
3dfeff5
to
ffb8b4b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64563496 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2914 +/- ##
=======================================
Coverage 95.67% 95.67%
=======================================
Files 502 502
Lines 49542 49542
=======================================
Hits 47400 47400
Misses 2142 2142 ☔ View full report in Codecov by Sentry. |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Oct 18, 2024
Summary: Earlier today danielcohenlive was having trouble using gs and was getting a weird modeling error. Lena did some investigation an found we were using the wrong method to grab pending points from the experiment. See her notebook in the test plan for more details. to quote "Basically in some settings it’s not safe to deem a point pending based on the trial status; generally no point for which we have data, we want to consider pending" I just am putting up the fix with her logic here Reviewed By: lena-kashtelyan, Cesar-Cardoso Differential Revision: D64563496
mgarrard
force-pushed
the
export-D64563496
branch
from
ffb8b4b
to
b8fc177
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64563496 |
Summary: Earlier today danielcohenlive was having trouble using gs and was getting a weird modeling error. Lena did some investigation an found we were using the wrong method to grab pending points from the experiment. See her notebook in the test plan for more details. to quote "Basically in some settings it’s not safe to deem a point pending based on the trial status; generally no point for which we have data, we want to consider pending" I just am putting up the fix with her logic here Reviewed By: lena-kashtelyan, Cesar-Cardoso Differential Revision: D64563496
mgarrard
force-pushed
the
export-D64563496
branch
from
b8fc177
to
797f0ee
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64563496 |
|
This pull request has been merged in 9c362ab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Earlier today danielcohenlive was having trouble using gs and was getting a weird modeling error. Lena did some investigation an found we were using the wrong method to grab pending points from the experiment. See her notebook in the test plan for more details. to quote "Basically in some settings it’s not safe to deem a point pending based on the trial status; generally no point for which we have data, we want to consider pending"
I just am putting up the fix with her logic here
Differential Revision: D64563496