Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop values without metric readings in ParallelCoordinatesPlot #2898

Closed
wants to merge 2 commits into from

Conversation

mpolson64
Copy link
Contributor

Summary: Bugfix. If an arm does not have a value for its metric it will fail to plot. Noticed this while working on something else

Differential Revision: D64496771

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 16, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64496771

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 95.66%. Comparing base (c7382f8) to head (e060008).

Files with missing lines Patch % Lines
ax/analysis/analysis.py 33.33% 4 Missing ⚠️
ax/analysis/markdown/markdown_analysis.py 0.00% 1 Missing ⚠️
ax/analysis/plotly/plotly_analysis.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2898      +/-   ##
==========================================
- Coverage   95.67%   95.66%   -0.01%     
==========================================
  Files         502      502              
  Lines       49532    49535       +3     
==========================================
  Hits        47390    47390              
- Misses       2142     2145       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Summary:

Display title and subtitle, and sort cards by level in display_cards. Useful for using with AxClient in a notebook.

Also add minimum_priority argument to display_cards, by default show everything but debug

Differential Revision: D64495780
…ook#2898)

Summary:

Bugfix. If an arm does not have a value for its metric it will fail to plot. Noticed this while working on something else

Differential Revision: D64496771
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64496771

mpolson64 added a commit to mpolson64/Ax that referenced this pull request Oct 18, 2024
…ook#2898)

Summary:

Bugfix. If an arm does not have a value for its metric it will fail to plot. Noticed this while working on something else

Reviewed By: danielcohenlive

Differential Revision: D64496771
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 4b1ba71.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants