Add logs for when data-fetching actually starts #2855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D64208425 |
facebook-github-bot
added
CLA Signed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2855 +/- ##
==========================================
- Coverage 95.78% 95.78% -0.01%
==========================================
Files 502 502
Lines 49687 49690 +3
==========================================
+ Hits 47593 47595 +2
- Misses 2094 2095 +1 ☔ View full report in Codecov by Sentry. |
lena-kashtelyan
force-pushed
the
export-D64208425
branch
from
8d3e95f
to
6c7d471
Compare
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Oct 14, 2024
Summary: Current logs are confusing, they make it look like we first fetch the data quite fast, then we retrieve completed trials, and then we do nothing for a while. This clarifies by rephrasing the "Fetching..." log to "will fetch" and logging the actual start of fetching with "..." at the end, indicating that it will take a bit. Reviewed By: Balandat Differential Revision: D64208425
|
This pull request was exported from Phabricator. Differential Revision: D64208425 |
lena-kashtelyan
force-pushed
the
export-D64208425
branch
from
6c7d471
to
394eed1
Compare
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Oct 14, 2024
Summary: Current logs are confusing, they make it look like we first fetch the data quite fast, then we retrieve completed trials, and then we do nothing for a while. This clarifies by rephrasing the "Fetching..." log to "will fetch" and logging the actual start of fetching with "..." at the end, indicating that it will take a bit. Reviewed By: Balandat Differential Revision: D64208425
|
This pull request was exported from Phabricator. Differential Revision: D64208425 |
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Oct 14, 2024
Summary: Current logs are confusing, they make it look like we first fetch the data quite fast, then we retrieve completed trials, and then we do nothing for a while. This clarifies by rephrasing the "Fetching..." log to "will fetch" and logging the actual start of fetching with "..." at the end, indicating that it will take a bit. Reviewed By: Balandat Differential Revision: D64208425
lena-kashtelyan
force-pushed
the
export-D64208425
branch
from
394eed1
to
e00a155
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64208425 |
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Oct 14, 2024
Summary: Current logs are confusing, they make it look like we first fetch the data quite fast, then we retrieve completed trials, and then we do nothing for a while. This clarifies by rephrasing the "Fetching..." log to "will fetch" and logging the actual start of fetching with "..." at the end, indicating that it will take a bit. Reviewed By: Balandat Differential Revision: D64208425
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Oct 15, 2024
Summary: Current logs are confusing, they make it look like we first fetch the data quite fast, then we retrieve completed trials, and then we do nothing for a while. This clarifies by rephrasing the "Fetching..." log to "will fetch" and logging the actual start of fetching with "..." at the end, indicating that it will take a bit. Reviewed By: Balandat Differential Revision: D64208425
lena-kashtelyan
force-pushed
the
export-D64208425
branch
from
e00a155
to
96a82bc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64208425 |
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Oct 15, 2024
Summary: Current logs are confusing, they make it look like we first fetch the data quite fast, then we retrieve completed trials, and then we do nothing for a while. This clarifies by rephrasing the "Fetching..." log to "will fetch" and logging the actual start of fetching with "..." at the end, indicating that it will take a bit. Reviewed By: Balandat Differential Revision: D64208425
lena-kashtelyan
force-pushed
the
export-D64208425
branch
from
96a82bc
to
e55b599
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64208425 |
Summary: Current logs are confusing, they make it look like we first fetch the data quite fast, then we retrieve completed trials, and then we do nothing for a while. This clarifies by rephrasing the "Fetching..." log to "will fetch" and logging the actual start of fetching with "..." at the end, indicating that it will take a bit. Reviewed By: Balandat Differential Revision: D64208425
lena-kashtelyan
force-pushed
the
export-D64208425
branch
from
e55b599
to
3b66e9e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64208425 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Current logs are confusing, they make it look like we first fetch the data quite fast, then we retrieve completed trials, and then we do nothing for a while. This clarifies by rephrasing the "Fetching..." log to "will fetch" and logging the actual start of fetching with "..." at the end, indicating that it will take a bit.
Differential Revision: D64208425