Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make objective direction checks more strict #2382

Closed
wants to merge 1 commit into from
Closed

Make objective direction checks more strict #2382

wants to merge 1 commit into from

Commits on Apr 19, 2024

  1. Make objective direction checks more strict (facebook#2382) 

    Summary:

With this change, at least one of `minimize` or `lower_is_better` must be specified. If both are specified, they must match.

Added a json storage helper & updated SQA storage helpers for deserializing previously saved objectives in a backwards compatible manner, resolving the conflicts in favor of `minimize`.

Differential Revision: D56315542
    @saitcakmak @facebook-github-bot
    saitcakmak authored and facebook-github-bot committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    d8c55df View commit details
    Browse the repository at this point in the history