Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable batched benchmarks (with BatchTrial) #2331

Closed
wants to merge 1 commit into from

Conversation

esantorella
Copy link
Contributor

Summary:

  • Add scheduler options for running benchmarks with BatchTrial
  • Append "_batch" to the name of MBM batched

Differential Revision: D55750921

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Apr 6, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55750921

esantorella added a commit to esantorella/Ax that referenced this pull request Apr 6, 2024
Summary:

- Add scheduler options for running benchmarks with BatchTrial
- Append "_batch" to the name of MBM batched

Differential Revision: D55750921
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55750921

esantorella added a commit to esantorella/Ax that referenced this pull request Apr 7, 2024
Summary:

- Add scheduler options for running benchmarks with BatchTrial
- Append "_batch" to the name of MBM batched

Differential Revision: D55750921
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55750921

@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2024

Codecov Report

Attention: Patch coverage is 95.55556% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 94.91%. Comparing base (adcf3a4) to head (7064d68).

❗ Current head 7064d68 differs from pull request most recent head 91d9d00. Consider uploading reports for the commit 91d9d00 to get more accurate results

Files Patch % Lines
ax/benchmark/benchmark_method.py 77.77% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2331   +/-   ##
=======================================
  Coverage   94.91%   94.91%           
=======================================
  Files         491      491           
  Lines       47788    47821   +33     
=======================================
+ Hits        45356    45390   +34     
+ Misses       2432     2431    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

esantorella added a commit to esantorella/Ax that referenced this pull request Apr 8, 2024
Summary:

- Add scheduler options for running benchmarks with BatchTrial
- Append "_batch" to the name of MBM batched

Differential Revision: D55750921
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55750921

esantorella added a commit to esantorella/Ax that referenced this pull request Apr 8, 2024
Summary:

- Add scheduler options for running benchmarks with BatchTrial
- Append "_batch" to the name of MBM batched

Reviewed By: Balandat

Differential Revision: D55750921
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55750921

esantorella added a commit to esantorella/Ax that referenced this pull request Apr 8, 2024
Summary:

- Add scheduler options for running benchmarks with BatchTrial
- Append "_batch" to the name of MBM batched

Reviewed By: Balandat

Differential Revision: D55750921
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55750921

esantorella added a commit to esantorella/Ax that referenced this pull request Apr 8, 2024
Summary:

- Add scheduler options for running benchmarks with BatchTrial
- Append "_batch" to the name of MBM batched

Reviewed By: Balandat

Differential Revision: D55750921
Summary:

- Add scheduler options for running benchmarks with BatchTrial
- Append "_batch" to the name of MBM batched

Reviewed By: Balandat

Differential Revision: D55750921
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55750921

esantorella added a commit to esantorella/Ax that referenced this pull request Apr 8, 2024
Summary:

- Add scheduler options for running benchmarks with BatchTrial
- Append "_batch" to the name of MBM batched

Reviewed By: Balandat

Differential Revision: D55750921
esantorella added a commit to esantorella/Ax that referenced this pull request Apr 8, 2024
Summary:

- Add scheduler options for running benchmarks with BatchTrial
- Append "_batch" to the name of MBM batched

Reviewed By: Balandat

Differential Revision: D55750921
esantorella added a commit to esantorella/Ax that referenced this pull request Apr 8, 2024
Summary:

- Add scheduler options for running benchmarks with BatchTrial
- Append "_batch" to the name of MBM batched

Reviewed By: Balandat

Differential Revision: D55750921
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in ad096e6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants