Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed concatenation to f-strings #2300

Closed
wants to merge 1 commit into from

Conversation

igeni
Copy link
Contributor

@igeni igeni commented Mar 23, 2024

Changed concatenation of strings to f-strings to avoid potential type's mismatch, simplify the code and unify it with others parts

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 23, 2024
@facebook-github-bot
Copy link
Contributor

@Balandat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.90%. Comparing base (3a701af) to head (aa1f923).

❗ Current head aa1f923 differs from pull request most recent head 73edc02. Consider uploading reports for the commit 73edc02 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2300   +/-   ##
=======================================
  Coverage   94.90%   94.90%           
=======================================
  Files         489      489           
  Lines       47656    47656           
=======================================
  Hits        45229    45229           
  Misses       2427     2427           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@facebook-github-bot
Copy link
Contributor

@Balandat merged this pull request in 87bf0ca.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants