Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submitit ask-tell tutorial #2127

Closed
wants to merge 4 commits into from

Conversation

mhavasi
Copy link

@mhavasi mhavasi commented Jan 10, 2024

Adds a tutorial that shows how to use the AxClient to schedule jobs and tune parameters on a Slurm cluster via SubmitIt.

Code changes:

  1. The tutorial notebook
  2. Linking the tutorial notebook for the website. (index.js, tutorials.json)

Testing:
Q: How can I make sure that this tutorial shows up correctly on the Ax doc site?

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 10, 2024
@mpolson64
Copy link
Contributor

Looks great! A couple notes (that I will just leave here since commenting on a .ipynb is annoying):

  • I can handle making sure this renders properly on the website. It's a little easier for me to do this once things have landed in fbsource so let's just get this in as is for now
  • Let's use exp_to_df(ax_client.experiment) instead of ax_client.generation_strategy.trials_as_df -- marginally better UX imo
  • Can we add a cell where we plot the response surface and optimization trace like we do here: https://ax.dev/tutorials/gpei_hartmann_service.html#6.-Plot-the-response-surface-and-optimization-trace ?
  • All the tutorials run locally during our testing, so can we comment out cluster='slurm' and replace with cluster='local' and a comment explaining that the cluster is set to local for testing purposes

@mpolson64
Copy link
Contributor

One last thing: no need to write the covariance since the demo problem only has one metric

@mhavasi
Copy link
Author

mhavasi commented Jan 11, 2024

Thanks so much for the comments! I fixed the nits and I did another grammar pass.

@facebook-github-bot
Copy link
Contributor

@mhavasi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@mhavasi merged this pull request in 894d392.

@Balandat
Copy link
Contributor

Balandat commented Feb 5, 2024

This is great, thanks for adding this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants