Remove Surrogate.from_botorch #1927
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This is buggy and unsupported. Reviewed By: Balandat Differential Revision: D50581677
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D50581677 |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 24, 2023
Summary: X-link: facebook/Ax#1927 This is buggy and unsupported. Reviewed By: Balandat Differential Revision: D50581677
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1927 +/- ##
=======================================
Coverage 94.58% 94.58%
=======================================
Files 459 459
Lines 43426 43402 -24
=======================================
- Hits 41074 41052 -22
+ Misses 2352 2350 -2
☔ View full report in Codecov by Sentry. |
facebook-github-bot
pushed a commit
to pytorch/botorch
that referenced
this pull request
Oct 24, 2023
Summary: Pull Request resolved: #2067 X-link: facebook/Ax#1927 This is buggy and unsupported. Reviewed By: Balandat Differential Revision: D50581677 fbshipit-source-id: 4df0a859b14687c0bbb5d9422e2a7a0f95a61686
|
This pull request has been merged in 3b82300. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This is buggy and unsupported.
Reviewed By: Balandat
Differential Revision: D50581677