-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tutorial execution to eliminate SIGTERM #1830
Conversation
@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1830 +/- ##
=======================================
Coverage 94.57% 94.57%
=======================================
Files 456 456
Lines 43010 43010
=======================================
Hits 40677 40677
Misses 2333 2333 ☔ View full report in Codecov by Sentry. |
@saitcakmak merged this pull request in eea5c03. |
The current tutorial script hangs for a while and produces
before moving onto executing the tutorials. Identified
ExecutePreprocessor
as the source of this and replaced it withpapermill
(code borrowed from BoTorch) to eliminate the issue.Example workflow before this diff: https://github.com/facebook/Ax/actions/runs/6125894824/job/16628813894
Workflow with this diff: https://github.com/facebook/Ax/actions/runs/6126463133/job/16630514050
The new one ran significantly faster!