Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix smoke test for SEBO tutorial #1826

Closed
wants to merge 1 commit into from
Closed

Conversation

saitcakmak
Copy link
Contributor

@saitcakmak saitcakmak commented Sep 8, 2023

For the AxClient parts, this was returning noise levels but using SingleTaskGP, which doesn't accept train_Yvar. Leaving the model type as None should dispatch the correct model type.

Test Plan: https://github.com/facebook/Ax/actions/runs/6117752845

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 8, 2023
@facebook-github-bot
Copy link
Contributor

@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (3a0669d) 94.57% compared to head (23428e3) 94.56%.

❗ Current head 23428e3 differs from pull request most recent head ec15515. Consider uploading reports for the commit ec15515 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1826      +/-   ##
==========================================
- Coverage   94.57%   94.56%   -0.01%     
==========================================
  Files         456      456              
  Lines       43010    43007       -3     
==========================================
- Hits        40677    40671       -6     
- Misses       2333     2336       +3     

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Balandat Balandat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@facebook-github-bot
Copy link
Contributor

@saitcakmak merged this pull request in 5da3e55.

@saitcakmak saitcakmak deleted the saitcakmak-patch-1 branch September 8, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants