Fix sebo tutorial #1801
Closed
Fix sebo tutorial #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Sebo tutorial was failing (marked "flaky" because it has never succeeded since creation) because it was not included in the target graph. Also, mixed use of options.get and options.pop was causing issues with input constructor validations. Both issues are resolved now. Finally, I changed the number of batches from 40 to 20. Let me know if this is acceptable -- it puts our runtime at 8:46 in opt mode which is still close to timeout but should be consistently safe. Reviewed By: esantorella Differential Revision: D48737511 fbshipit-source-id: 9eace1efee74045591ad594d7f61a96517c152d1
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48737511 |
|
This pull request has been merged in 907c8fb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Sebo tutorial was failing (marked "flaky" because it has never succeeded since creation) because it was not included in the target graph. Also, mixed use of options.get and options.pop was causing issues with input constructor validations. Both issues are resolved now.
Finally, I changed the number of batches from 40 to 20. Let me know if this is acceptable -- it puts our runtime at 8:46 in opt mode which is still close to timeout but should be consistently safe.
Reviewed By: esantorella
Differential Revision: D48737511