Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tutorial dependencies #1762

Closed
wants to merge 1 commit into from
Closed

Update tutorial dependencies #1762

wants to merge 1 commit into from

Conversation

saitcakmak
Copy link
Contributor

@saitcakmak saitcakmak commented Aug 4, 2023

PyArrow is required to avoid the tutorial failures seen in the nightly cron: https://github.com/facebook/Ax/actions/runs/5758595848/job/15611390170

Smoke-test tutorial runs:
On current main: https://github.com/facebook/Ax/actions/runs/5764907837
On this PR: https://github.com/facebook/Ax/actions/runs/5764906547

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 4, 2023
@mpolson64
Copy link
Contributor

Thanks for catching this! I was just about to put a diff up myself but this is perfect.

@facebook-github-bot
Copy link
Contributor

@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (81526d7) 94.38% compared to head (7967688) 94.38%.

❗ Current head 7967688 differs from pull request most recent head bf7c3ed. Consider uploading reports for the commit bf7c3ed to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1762   +/-   ##
=======================================
  Coverage   94.38%   94.38%           
=======================================
  Files         454      454           
  Lines       42493    42493           
=======================================
  Hits        40107    40107           
  Misses       2386     2386           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@facebook-github-bot
Copy link
Contributor

@saitcakmak merged this pull request in b94922f.

@saitcakmak saitcakmak deleted the saitcakmak-patch-4 branch September 7, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants