Skip to content

Commit

Permalink
Get rid of BotorchTestProblemRunner (#2945)
Browse files Browse the repository at this point in the history
Summary:

It's redundant as per previous diff.

Reviewed By: saitcakmak

Differential Revision: D63722334
  • Loading branch information
esantorella authored and facebook-github-bot committed Oct 24, 2024
1 parent a85c7ee commit 9e672a4
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
3 changes: 0 additions & 3 deletions ax/benchmark/runners/botorch_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,3 @@ def get_Y_true(self, params: Mapping[str, TParamValue]) -> Tensor:
dim=-1,
)
return Y_true


BotorchTestProblemRunner = ParamBasedTestProblemRunner
6 changes: 3 additions & 3 deletions ax/storage/tests/test_registry_bundle.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
# pyre-strict

from ax.benchmark.benchmark_metric import BenchmarkMetric
from ax.benchmark.runners.botorch_test import BotorchTestProblemRunner
from ax.benchmark.runners.botorch_test import ParamBasedTestProblemRunner
from ax.metrics.branin import BraninMetric
from ax.runners.synthetic import SyntheticRunner
from ax.storage.registry_bundle import RegistryBundle
Expand All @@ -26,7 +26,7 @@ def test_from_registry_bundles(self) -> None:

right = RegistryBundle(
metric_clss={BenchmarkMetric: None},
runner_clss={BotorchTestProblemRunner: None},
runner_clss={ParamBasedTestProblemRunner: None},
json_encoder_registry={},
json_class_encoder_registry={},
json_decoder_registry={},
Expand All @@ -41,4 +41,4 @@ def test_from_registry_bundles(self) -> None:
self.assertIn(BraninMetric, combined.encoder_registry)
self.assertIn(SyntheticRunner, combined.encoder_registry)
self.assertIn(BenchmarkMetric, combined.encoder_registry)
self.assertIn(BotorchTestProblemRunner, combined.encoder_registry)
self.assertIn(ParamBasedTestProblemRunner, combined.encoder_registry)

0 comments on commit 9e672a4

Please sign in to comment.